imanghafoori1/laravel-widgetize

View on GitHub

Showing 63 of 63 total issues

Define a constant instead of duplicating this literal "plain" 3 times.
Open

        if (! $this->option('plain')) {
Severity: Critical
Found in src/WidgetGenerator.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Rename "$slots" which has the same name as the field declared at line 9.
Open

        $slots = $this->slots;
Severity: Major
Found in src/Utils/SlotRenderer.php by sonar-php

Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

Noncompliant Code Example

class Foo {
  public $myField;

  public function doSomething() {
    $myField = 0;
    ...
  }
}

See

Rename "$expression" which has the same name as the field declared at line 11.
Open

            $expression = $this->expression;
Severity: Major
Found in src/WidgetsServiceProvider.php by sonar-php

Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

Noncompliant Code Example

class Foo {
  public $myField;

  public function doSomething() {
    $myField = 0;
    ...
  }
}

See

Severity
Category
Status
Source
Language