Sign upLogin

immaterial-design/immaterial-design-ripple

View on GitHub
Star

Showing 10 of 10 total issues

Function createRenderSchedule has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

export function createRenderSchedule(x, y, width, height, options = {}) {
  const opts = Object.create(options);
  if (opts.pixelSize === undefined) {
    opts.pixelSize = 1;
  }
Severity: Minor
Found in src/utility.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function play has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  static play(x, y, width, height, options = {}) {
    const opts = objectAssign({
      pixelSize: Math.floor(height / 10),
      bitCrash: 7,
      pixelated: true,
Severity: Minor
Found in src/index.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function play has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static play(x, y, width, height, options = {}) {
    const opts = objectAssign({
      pixelSize: Math.floor(height / 10),
      bitCrash: 7,
      pixelated: true,
Severity: Minor
Found in src/index.js - About 1 hr to fix

    Function createRenderSchedule has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function createRenderSchedule(x, y, width, height, options = {}) {
  const opts = Object.create(options);
  if (opts.pixelSize === undefined) {
    opts.pixelSize = 1;
  }
    Severity: Minor
    Found in src/utility.js - About 1 hr to fix

      Function promise has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const promise = new Promise((resolve) => {
      let frame = 0;
      const render = () => {
        if (promise.disabled) {
          return resolve(context);
      Severity: Minor
      Found in src/index.js - About 1 hr to fix

        Function constructor has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          constructor(element, options = {}) {
    super();

    /**
    * @public
        Severity: Minor
        Found in src/index.js - About 1 hr to fix

          Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                const render = () => {
        if (promise.disabled) {
          return resolve(context);
        }
          Severity: Minor
          Found in src/index.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  this.play(x, y, objectAssign({ exitBefore: 'mouseup' }, options))
      .then(() => {
        this.emit('end');
      });
            Severity: Minor
            Found in src/index.js and 1 other location - About 40 mins to fix
            src/index.js on lines 84..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  this.play(x, y, objectAssign({ exitBefore: 'touchend' }, options))
      .then(() => {
        this.emit('end');
      });
            Severity: Minor
            Found in src/index.js and 1 other location - About 40 mins to fix
            src/index.js on lines 72..75

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function createRenderSchedule has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            export function createRenderSchedule(x, y, width, height, options = {}) {
            Severity: Minor
            Found in src/utility.js - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language