immense/php-macaroons

View on GitHub

Showing 65 of 65 total issues

The method base64_url_encode is not named in camelCase.
Open

  public static function base64_url_encode($data)
  {
    return str_replace('=', '', self::base64_url_safe_encode($data));
  }
Severity: Minor
Found in lib/Macaroons/Utils.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method base64_url_decode is not named in camelCase.
Open

  public static function base64_url_decode($data)
  {
    return self::base64_url_safe_decode(str_pad($data, (4 - (strlen($data) % 4)) % 4, '=', STR_PAD_RIGHT));
  }
Severity: Minor
Found in lib/Macaroons/Utils.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method base64_strict_encode is not named in camelCase.
Open

  public static function base64_strict_encode($data)
  {
    $data = str_replace("\r\n", '', base64_encode($data));
    $data = str_replace("\r", '', $data);
    return str_replace("\n", '', $data);
Severity: Minor
Found in lib/Macaroons/Utils.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method base64_url_safe_decode is not named in camelCase.
Open

  public static function base64_url_safe_decode($data)
  {
    $data = str_replace('-', '+', $data);
    $data = str_replace('_', '/', $data);
    return base64_decode($data);
Severity: Minor
Found in lib/Macaroons/Utils.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

TODO found
Open

  // TODO: Move these into a separate object
Severity: Minor
Found in lib/Macaroons/Macaroon.php by fixme
Severity
Category
Status
Source
Language