Sign upLogin

imrefazekas/connect-rest

View on GitHub
Star

Showing 42 of 42 total issues

Function innerMatches has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

Path.prototype.innerMatches = function ( requestPath, parameterReplacements ) {
    let self = this

    if ( self.isOpengate )
        return true
Severity: Minor
Found in lib/util/Path.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if ( this.config.discover && this.config.discover.path ) {
        this.logger.restlog( null, 'dicover service activated on path: ' + this.config.discover.path + '/:version', null, 'info' )
        this.addPath('GET', { path: this.config.discover.path + '/:version', unprotected: !this.config.discover.secure }, discover(this.mapping) )
    }
Severity: Major
Found in lib/Rest.js and 1 other location - About 4 hrs to fix
lib/Rest.js on lines 72..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if ( this.config.proto && this.config.proto.path ) {
        this.logger.restlog( null, 'proto service activated on path: ' + this.config.proto.path + '/*path', null, 'info' )
        this.addPath('GET', { path: this.config.proto.path + '/*path', unprotected: !this.config.discover.secure }, protoPather(this.mapping) )
    }
Severity: Major
Found in lib/Rest.js and 1 other location - About 4 hrs to fix
lib/Rest.js on lines 68..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function process has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

exports.process = async function (req, res, action, bodyObj) {
    let self = this

    self.logger.restlog( null, 'Process request', { body: bodyObj }, 'trace' )
Severity: Minor
Found in lib/services/Performer.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function matches has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

Path.prototype.matches = function ( req, pathname, version, alterEnvironment, protectAPI ) {
    if ( !( pathname.startsWith( this.context ) ) )
        return false
    let rPathname = pathname.substring( this.context.length )
Severity: Minor
Found in lib/util/Path.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function purify has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

function purify ( obj, config, level, path ) {
    config = config || defaultPurifyConfig
    if (!obj) return obj
    if ( _.isDate(obj) || _.isBoolean(obj) || _.isNumber(obj) || _.isString(obj) || _.isRegExp(obj) )
        return obj
Severity: Minor
Found in lib/services/Performer.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function process has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.process = async function (req, res, action, bodyObj) {
    let self = this

    self.logger.restlog( null, 'Process request', { body: bodyObj }, 'trace' )
Severity: Major
Found in lib/services/Performer.js - About 2 hrs to fix

    Function minify has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.minify = function (json) {
    let tokenizer = /"|'|(\/\*)|(\*\/)|(\/\/)|\n|\r/g,
        in_string = false,
        in_multiline_comment = false,
        in_singleline_comment = false,
    Severity: Minor
    Found in lib/util/Converter.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generalCall has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    httpHelper.generalCall = async function (serverURL, method, options = {}) {
    let self = this

    return new Promise( (resolve, reject) => {
        let server = _.isString( serverURL ) ? url.parse( serverURL ) : serverURL
    Severity: Minor
    Found in lib/util/HttpHelper.js - About 2 hrs to fix

      Function innerMatches has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Path.prototype.innerMatches = function ( requestPath, parameterReplacements ) {
    let self = this

    if ( self.isOpengate )
        return true
      Severity: Minor
      Found in lib/util/Path.js - About 1 hr to fix

        Function minify has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.minify = function (json) {
    let tokenizer = /"|'|(\/\*)|(\*\/)|(\/\/)|\n|\r/g,
        in_string = false,
        in_multiline_comment = false,
        in_singleline_comment = false,
        Severity: Minor
        Found in lib/util/Converter.js - About 1 hr to fix

          Function Path has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          function Path (context, path, config ) {
    this.path = path

    this.config = config || {}
          Severity: Minor
          Found in lib/util/Path.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function Rest has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function Rest ( config ) {
    this.config = {
        options: config.options,
        context: config.context ? config.context : (config.context === '' ? '' : '/api'),
        headers: config.headers || { },
          Severity: Minor
          Found in lib/Rest.js - About 1 hr to fix

            Function perform has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            exports.perform = function ( req, res, next ) {
    let self = this

    let router = self.getRouterMatching( req, res )
            Severity: Minor
            Found in lib/services/Performer.js - About 1 hr to fix

              Function matches has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              Path.prototype.matches = function ( req, pathname, version, alterEnvironment, protectAPI ) {
    if ( !( pathname.startsWith( this.context ) ) )
        return false
    let rPathname = pathname.substring( this.context.length )
              Severity: Minor
              Found in lib/util/Path.js - About 1 hr to fix

                Function purify has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function purify ( obj, config, level, path ) {
    config = config || defaultPurifyConfig
    if (!obj) return obj
    if ( _.isDate(obj) || _.isBoolean(obj) || _.isNumber(obj) || _.isString(obj) || _.isRegExp(obj) )
        return obj
                Severity: Minor
                Found in lib/services/Performer.js - About 1 hr to fix

                  Function returnResult has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function returnResult ( err, result, res, globalHeaders ) {
    let headers = assigner.assign( {}, globalHeaders || {} )
    if ( err ) {
        headers = assigner.assign( headers, { 'Content-Type': 'text/plain' } )
        setHeaders( res, err.statusCode || 500, headers )
                  Severity: Minor
                  Found in lib/services/Performer.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function perform has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  exports.perform = function ( req, res, next ) {
    let self = this

    let router = self.getRouterMatching( req, res )
                  Severity: Minor
                  Found in lib/services/Performer.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function upload has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  httpHelper.upload = async function (serverURL, query, refName, fileName, contentType, fileStream ) {
                  Severity: Minor
                  Found in lib/util/HttpHelper.js - About 45 mins to fix

                    Function Rest has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function Rest ( config ) {
    this.config = {
        options: config.options,
        context: config.context ? config.context : (config.context === '' ? '' : '/api'),
        headers: config.headers || { },
                    Severity: Minor
                    Found in lib/Rest.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language