Sign upLogin

imrefazekas/connect-rest

View on GitHub
Star
lib/util/HttpHelper.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function generalCall has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

httpHelper.generalCall = async function (serverURL, method, options = {}) {
    let self = this

    return new Promise( (resolve, reject) => {
        let server = _.isString( serverURL ) ? url.parse( serverURL ) : serverURL
Severity: Minor
Found in lib/util/HttpHelper.js - About 2 hrs to fix

    Function upload has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    httpHelper.upload = async function (serverURL, query, refName, fileName, contentType, fileStream ) {
    Severity: Minor
    Found in lib/util/HttpHelper.js - About 45 mins to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      httpHelper.post = async function (serverURL, query, payload) {
    return this.payload(payload).generalCall( serverURL + getQuery(query), 'POST' )
}
      Severity: Major
      Found in lib/util/HttpHelper.js and 4 other locations - About 35 mins to fix
      lib/util/HttpHelper.js on lines 74..76
      lib/util/HttpHelper.js on lines 80..82
      lib/util/HttpHelper.js on lines 83..85
      lib/util/HttpHelper.js on lines 86..88

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      httpHelper.put = async function (serverURL, query, payload) {
    return this.payload(payload).generalCall( serverURL + getQuery(query), 'PUT' )
}
      Severity: Major
      Found in lib/util/HttpHelper.js and 4 other locations - About 35 mins to fix
      lib/util/HttpHelper.js on lines 74..76
      lib/util/HttpHelper.js on lines 77..79
      lib/util/HttpHelper.js on lines 83..85
      lib/util/HttpHelper.js on lines 86..88

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      httpHelper.patch = async function (serverURL, query, payload) {
    return this.payload(payload).generalCall( serverURL + getQuery(query), 'PATCH' )
}
      Severity: Major
      Found in lib/util/HttpHelper.js and 4 other locations - About 35 mins to fix
      lib/util/HttpHelper.js on lines 74..76
      lib/util/HttpHelper.js on lines 77..79
      lib/util/HttpHelper.js on lines 80..82
      lib/util/HttpHelper.js on lines 86..88

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      httpHelper.get = async function (serverURL, query, payload) {
    return this.payload(payload).generalCall( serverURL + getQuery(query), 'GET' )
}
      Severity: Major
      Found in lib/util/HttpHelper.js and 4 other locations - About 35 mins to fix
      lib/util/HttpHelper.js on lines 77..79
      lib/util/HttpHelper.js on lines 80..82
      lib/util/HttpHelper.js on lines 83..85
      lib/util/HttpHelper.js on lines 86..88

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      httpHelper.del = async function (serverURL, query, payload) {
    return this.payload(payload).generalCall( serverURL + getQuery(query), 'DELETE' )
}
      Severity: Major
      Found in lib/util/HttpHelper.js and 4 other locations - About 35 mins to fix
      lib/util/HttpHelper.js on lines 74..76
      lib/util/HttpHelper.js on lines 77..79
      lib/util/HttpHelper.js on lines 80..82
      lib/util/HttpHelper.js on lines 83..85

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              for ( let key of Object.keys( defaultOPTS.headers ) )
            OPTS.headers[key] = defaultOPTS.headers[key]
      Severity: Minor
      Found in lib/util/HttpHelper.js and 1 other location - About 30 mins to fix
      lib/util/Dispatcher.js on lines 19..20

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status