inasafe/inasafe

View on GitHub
safe/common/utilities.py

Summary

Maintainability
D
1 day
Test Coverage

File utilities.py has 506 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# coding=utf-8

"""Utilities for InaSAFE."""

import colorsys
Severity: Major
Found in safe/common/utilities.py - About 1 day to fix

    Avoid too many return statements within this function.
    Wontfix

        return formatted_decimal
    Severity: Major
    Found in safe/common/utilities.py - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          try:
              p = Popen('free -m', shell=True, stdout=PIPE, encoding='utf8')
              stdout_string = p.communicate()[0].split('\n')[2]
          except OSError:
              raise OSError
      Severity: Major
      Found in safe/common/utilities.py and 1 other location - About 2 hrs to fix
      safe/common/utilities.py on lines 261..271

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          try:
              p = Popen('echo -e "\n$(top -l 1 | awk \'/PhysMem/\';)\n"',
                        shell=True, stdout=PIPE, encoding='utf8')
              stdout_string = p.communicate()[0].split('\n')[1]
              # e.g. output (its a single line) OSX 10.9 Mavericks
      Severity: Major
      Found in safe/common/utilities.py and 1 other location - About 2 hrs to fix
      safe/common/utilities.py on lines 245..249

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status