inasafe/inasafe

View on GitHub
safe/definitions/provenance.py

Summary

Maintainability
C
1 day
Test Coverage

File provenance.py has 336 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# coding=utf-8
"""Provenance Keys."""

from safe.definitions.layer_purposes import (
    layer_purpose_exposure_summary,
Severity: Minor
Found in safe/definitions/provenance.py - About 4 hrs to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    provenance_layer_profiling_id = {
        'key': 'provenance_layer_profiling_id',
        'name': layer_purpose_profiling['name'] + ' ID',
        'provenance_key': layer_purpose_profiling['key'] + '_id'
    Severity: Major
    Found in safe/definitions/provenance.py and 5 other locations - About 55 mins to fix
    safe/definitions/provenance.py on lines 270..273
    safe/definitions/provenance.py on lines 275..278
    safe/definitions/provenance.py on lines 280..283
    safe/definitions/provenance.py on lines 285..288
    safe/definitions/provenance.py on lines 290..293

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    provenance_layer_aggregate_hazard_impacted_id = {
        'key': 'provenance_layer_aggregate_hazard_impacted_id',
        'name': layer_purpose_aggregate_hazard_impacted['name'] + ' ID',
        'provenance_key': layer_purpose_aggregate_hazard_impacted['key'] + '_id'
    Severity: Major
    Found in safe/definitions/provenance.py and 5 other locations - About 55 mins to fix
    safe/definitions/provenance.py on lines 270..273
    safe/definitions/provenance.py on lines 280..283
    safe/definitions/provenance.py on lines 285..288
    safe/definitions/provenance.py on lines 290..293
    safe/definitions/provenance.py on lines 295..298

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    provenance_layer_exposure_summary_table_id = {
        'key': 'provenance_layer_exposure_summary_table_id',
        'name': layer_purpose_exposure_summary_table['name'] + ' ID',
        'provenance_key': layer_purpose_exposure_summary_table['key'] + '_id'
    Severity: Major
    Found in safe/definitions/provenance.py and 5 other locations - About 55 mins to fix
    safe/definitions/provenance.py on lines 270..273
    safe/definitions/provenance.py on lines 275..278
    safe/definitions/provenance.py on lines 280..283
    safe/definitions/provenance.py on lines 285..288
    safe/definitions/provenance.py on lines 295..298

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    provenance_layer_analysis_impacted_id = {
        'key': 'provenance_layer_analysis_impacted_id',
        'name': layer_purpose_analysis_impacted['name'] + ' ID',
        'provenance_key': layer_purpose_analysis_impacted['key'] + '_id'
    Severity: Major
    Found in safe/definitions/provenance.py and 5 other locations - About 55 mins to fix
    safe/definitions/provenance.py on lines 270..273
    safe/definitions/provenance.py on lines 275..278
    safe/definitions/provenance.py on lines 280..283
    safe/definitions/provenance.py on lines 290..293
    safe/definitions/provenance.py on lines 295..298

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    provenance_layer_aggregation_summary_id = {
        'key': 'provenance_layer_aggregation_summary_id',
        'name': layer_purpose_aggregation_summary['name'] + ' ID',
        'provenance_key': layer_purpose_aggregation_summary['key'] + '_id'
    Severity: Major
    Found in safe/definitions/provenance.py and 5 other locations - About 55 mins to fix
    safe/definitions/provenance.py on lines 270..273
    safe/definitions/provenance.py on lines 275..278
    safe/definitions/provenance.py on lines 285..288
    safe/definitions/provenance.py on lines 290..293
    safe/definitions/provenance.py on lines 295..298

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    provenance_layer_exposure_summary_id = {
        'key': 'provenance_layer_exposure_summary_id',
        'name': layer_purpose_exposure_summary['name'] + ' ID',
        'provenance_key': layer_purpose_exposure_summary['key'] + '_id'
    Severity: Major
    Found in safe/definitions/provenance.py and 5 other locations - About 55 mins to fix
    safe/definitions/provenance.py on lines 275..278
    safe/definitions/provenance.py on lines 280..283
    safe/definitions/provenance.py on lines 285..288
    safe/definitions/provenance.py on lines 290..293
    safe/definitions/provenance.py on lines 295..298

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status