Sign upLogin

inasafe/inasafe

View on GitHub
Star
safe/report/extractors/infographic_elements/svg_charts.py

Summary

Maintainability
D
2 days
Test Coverage

File svg_charts.py has 384 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# coding=utf-8
"""Module to generate context for SVG Chart.

This context then used for SVG Jinja2 generation.
"""
Severity: Minor
Found in safe/report/extractors/infographic_elements/svg_charts.py - About 5 hrs to fix

    Function _arc_slice_context has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _arc_slice_context(
    Severity: Major
    Found in safe/report/extractors/infographic_elements/svg_charts.py - About 1 hr to fix

      Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(
      Severity: Major
      Found in safe/report/extractors/infographic_elements/svg_charts.py - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                d += outer_arc_syntax.format(
            # center of donut
            center_x=radius,
            center_y=radius,
            # arc not skewed
        Severity: Major
        Found in safe/report/extractors/infographic_elements/svg_charts.py and 1 other location - About 4 hrs to fix
        safe/report/extractors/infographic_elements/svg_charts.py on lines 454..467

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    d += inner_arc_syntax.format(
                # center of donut
                center_x=hole,
                center_y=hole,
                # arc not skewed
        Severity: Major
        Found in safe/report/extractors/infographic_elements/svg_charts.py and 1 other location - About 4 hrs to fix
        safe/report/extractors/infographic_elements/svg_charts.py on lines 424..437

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status