Sign upLogin

inasafe/inasafe

View on GitHub
Star
safe/utilities/pivot_table.py

Summary

Maintainability
B
4 hrs
Test Coverage

File pivot_table.py has 261 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# coding=utf-8
"""InaSAFE Disaster risk assessment tool developed by AusAid

Contact : ole.moller.nielsen@gmail.com
Severity: Minor
Found in safe/utilities/pivot_table.py - About 2 hrs to fix

    Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, flat_table,
    Severity: Major
    Found in safe/utilities/pivot_table.py - About 50 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if row_field is None:
            self.rows = ['']
        else:
            self.rows = flat_table.group_values(row_field)
      Severity: Minor
      Found in safe/utilities/pivot_table.py and 1 other location - About 35 mins to fix
      safe/utilities/pivot_table.py on lines 268..273

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if columns is not None:
            self.columns = columns
        elif column_field is None:
            self.columns = ['']
        else:
      Severity: Minor
      Found in safe/utilities/pivot_table.py and 1 other location - About 35 mins to fix
      safe/utilities/pivot_table.py on lines 262..265

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status