inasafe/inasafe

View on GitHub
safe/utilities/qgis_utilities.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function display_critical_message_bar has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def display_critical_message_bar(
Severity: Minor
Found in safe/utilities/qgis_utilities.py - About 45 mins to fix

    Function display_success_message_bar has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def display_success_message_bar(
    Severity: Minor
    Found in safe/utilities/qgis_utilities.py - About 45 mins to fix

      Function display_information_message_bar has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def display_information_message_bar(
      Severity: Minor
      Found in safe/utilities/qgis_utilities.py - About 45 mins to fix

        Function display_warning_message_bar has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def display_warning_message_bar(
        Severity: Minor
        Found in safe/utilities/qgis_utilities.py - About 45 mins to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Wontfix

          def display_warning_message_bar(
                  title=None,
                  message=None,
                  more_details=None,
                  button_text=tr('Show details ...'),
          Severity: Major
          Found in safe/utilities/qgis_utilities.py and 3 other locations - About 1 day to fix
          safe/utilities/qgis_utilities.py on lines 30..71
          safe/utilities/qgis_utilities.py on lines 74..116
          safe/utilities/qgis_utilities.py on lines 190..233

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 128.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Wontfix

          def display_critical_message_bar(
                  title=None,
                  message=None,
                  more_details=None,
                  button_text=tr('Show details ...'),
          Severity: Major
          Found in safe/utilities/qgis_utilities.py and 3 other locations - About 1 day to fix
          safe/utilities/qgis_utilities.py on lines 30..71
          safe/utilities/qgis_utilities.py on lines 74..116
          safe/utilities/qgis_utilities.py on lines 132..174

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 128.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Wontfix

          def display_information_message_bar(
                  title=None,
                  message=None,
                  more_details=None,
                  button_text=tr('Show details ...'),
          Severity: Major
          Found in safe/utilities/qgis_utilities.py and 3 other locations - About 1 day to fix
          safe/utilities/qgis_utilities.py on lines 74..116
          safe/utilities/qgis_utilities.py on lines 132..174
          safe/utilities/qgis_utilities.py on lines 190..233

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 128.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Wontfix

          def display_success_message_bar(
                  title=None,
                  message=None,
                  more_details=None,
                  button_text=tr('Show details ...'),
          Severity: Major
          Found in safe/utilities/qgis_utilities.py and 3 other locations - About 1 day to fix
          safe/utilities/qgis_utilities.py on lines 30..71
          safe/utilities/qgis_utilities.py on lines 132..174
          safe/utilities/qgis_utilities.py on lines 190..233

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 128.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status