Sign upLogin

indentlabs/notebook

View on GitHub
Star
app/authorizers/timeline_authorizer.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method readable_by? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def readable_by?(user)
    return true if resource.privacy == 'public'
    return true if user && resource.user_id == user.id
    return true if resource.universe.present? && resource.universe.privacy == 'public'
    return true if user && resource.universe.present? && resource.universe.user_id == user.id
Severity: Minor
Found in app/authorizers/timeline_authorizer.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

    return false
Severity: Major
Found in app/authorizers/timeline_authorizer.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        return true if user && resource.universe.present? && resource.universe.contributors.pluck(:user_id).include?(user.id)
    Severity: Major
    Found in app/authorizers/timeline_authorizer.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return true if user && user.site_administrator?
      Severity: Major
      Found in app/authorizers/timeline_authorizer.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status