Sign upLogin

indentlabs/notebook

View on GitHub
Star
app/controllers/subscriptions_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method redeem_code has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def redeem_code
    code = PageUnlockPromoCode.find_by(code: params.require(:promotional_code).permit(:promo_code)[:promo_code])

    if code.nil?
      redirect_back(fallback_location: subscription_path, alert: "This isn't a valid promo code.")
Severity: Minor
Found in app/controllers/subscriptions_controller.rb - About 1 hr to fix

    Method information_change has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def information_change
    valid_token = params[:stripeToken]
    if valid_token.nil?
      flash[:alert] = "We couldn't validate the card information you entered. Please make sure you have Javascript enabled in your browser."
      return redirect_back fallback_location: payment_info_path
    Severity: Minor
    Found in app/controllers/subscriptions_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status