Sign upLogin

indentlabs/notebook

View on GitHub
Star
app/services/documents/analysis/third_party/ibm_watson_service.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method analyze has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def self.analyze(analysis_id)
          analysis = ::DocumentAnalysis.find(analysis_id)
          document = analysis.document

          watson_client = new_client
Severity: Major
Found in app/services/documents/analysis/third_party/ibm_watson_service.rb - About 2 hrs to fix

    Method analyze_entity has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def self.analyze_entity(document_entity)
          watson_client = new_client

          entity = ::DocumentEntity.find(document_entity.to_i) # raises unless found :+1:
          analysis = entity.document_analysis
    Severity: Minor
    Found in app/services/documents/analysis/third_party/ibm_watson_service.rb - About 1 hr to fix

      Method analyze has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def self.analyze(analysis_id)
          analysis = ::DocumentAnalysis.find(analysis_id)
          document = analysis.document

          watson_client = new_client
      Severity: Minor
      Found in app/services/documents/analysis/third_party/ibm_watson_service.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status