Sign upLogin

indentlabs/notebook

View on GitHub
Star
app/services/forum_replacement_service.rb

Summary

Maintainability
C
1 day
Test Coverage

File forum_replacement_service.rb has 503 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class ForumReplacementService < Service
  # Cool replacements we could eventually do not for pranking
  # [roll N] = random number between 1 and N
  # [roll N, M] = random number between N and M
  # [@reader] = username of the reader
Severity: Major
Found in app/services/forum_replacement_service.rb - About 1 day to fix

    Method replace_for has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.replace_for(text, user)
    gremlins_phase = 0
    replaced_text = text.dup

    # Page tag replacements
    Severity: Minor
    Found in app/services/forum_replacement_service.rb - About 1 hr to fix

      Method replace_for has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.replace_for(text, user)
    gremlins_phase = 0
    replaced_text = text.dup

    # Page tag replacements
      Severity: Minor
      Found in app/services/forum_replacement_service.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status