Sign upLogin

indentlabs/notebook

View on GitHub
Star
app/services/temporary_field_migration_service.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method migrate_fields_for_content has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def self.migrate_fields_for_content(content_model, user, force: false)
    return unless content_model.present? && user.present?
    return unless content_model.user == user
    return if content_model.is_a?(ContentPage)
    return if !force && content_model.persisted? && content_model.created_at > 'May 1, 2018'.to_datetime
Severity: Minor
Found in app/services/temporary_field_migration_service.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method migrate_fields_for_content has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.migrate_fields_for_content(content_model, user, force: false)
    return unless content_model.present? && user.present?
    return unless content_model.user == user
    return if content_model.is_a?(ContentPage)
    return if !force && content_model.persisted? && content_model.created_at > 'May 1, 2018'.to_datetime
Severity: Major
Found in app/services/temporary_field_migration_service.rb - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

          return # hurrah!
    Severity: Major
    Found in app/services/temporary_field_migration_service.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return if !!content_model.columns_migrated_from_old_style?
      Severity: Major
      Found in app/services/temporary_field_migration_service.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status