Sign upLogin

indentlabs/notebook

View on GitHub
Star

Showing 288 of 288 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            <a href={this.content_page_view_path(this.state.page_type, this.state.page_id)}>
              <ListItem button>
                <i className={"blue-text material-icons left"}>
                  { this.classIcon(this.state.page_type) }
                </i>
Severity: Major
Found in app/javascript/components/PageLookupSidebar.js and 1 other location - About 4 hrs to fix
app/javascript/components/PageLookupSidebar.js on lines 281..288

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

              <div className="spinner-layer spinner-green">
                <div className="circle-clipper left">
                  <div className="circle"></div>
                </div><div className="gap-patch">
                  <div className="circle"></div>
Severity: Major
Found in app/javascript/components/PageLookupSidebar.js and 3 other locations - About 4 hrs to fix
app/javascript/components/PageLookupSidebar.js on lines 320..328
app/javascript/components/PageLookupSidebar.js on lines 330..338
app/javascript/components/PageLookupSidebar.js on lines 340..348

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method json_export has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

  def self.json_export(universe_ids)
    page_types = Rails.application.config.content_types[:all]
    temporary_user_id_reference = Universe.find_by(id: universe_ids).user_id

    export_object = {}
Severity: Minor
Found in app/services/export_service.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

              <div className="spinner-layer spinner-blue">
                <div className="circle-clipper left">
                  <div className="circle"></div>
                </div><div className="gap-patch">
                  <div className="circle"></div>
Severity: Major
Found in app/javascript/components/PageLookupSidebar.js and 3 other locations - About 4 hrs to fix
app/javascript/components/PageLookupSidebar.js on lines 330..338
app/javascript/components/PageLookupSidebar.js on lines 340..348
app/javascript/components/PageLookupSidebar.js on lines 350..358

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

              <div className="spinner-layer spinner-red">
                <div className="circle-clipper left">
                  <div className="circle"></div>
                </div><div className="gap-patch">
                  <div className="circle"></div>
Severity: Major
Found in app/javascript/components/PageLookupSidebar.js and 3 other locations - About 4 hrs to fix
app/javascript/components/PageLookupSidebar.js on lines 320..328
app/javascript/components/PageLookupSidebar.js on lines 340..348
app/javascript/components/PageLookupSidebar.js on lines 350..358

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

              <div className="spinner-layer spinner-yellow">
                <div className="circle-clipper left">
                  <div className="circle"></div>
                </div><div className="gap-patch">
                  <div className="circle"></div>
Severity: Major
Found in app/javascript/components/PageLookupSidebar.js and 3 other locations - About 4 hrs to fix
app/javascript/components/PageLookupSidebar.js on lines 320..328
app/javascript/components/PageLookupSidebar.js on lines 330..338
app/javascript/components/PageLookupSidebar.js on lines 350..358

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function constructor has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(el) {
    this.el = el;
    if (!(this.el.length > 0)) { return; }

    window.editor = new MediumEditor('#editor', {
Severity: Major
Found in app/assets/javascripts/document_editor.js - About 4 hrs to fix

    Function constructor has 106 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      constructor(props) {
    super(props);

    this.state = {
      'open': false
    Severity: Major
    Found in app/javascript/components/QuickActionsSidebar.js - About 4 hrs to fix

      Function mindmap has 103 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        $.fn.mindmap = function (options) {
    // Define default settings.
    options = $.extend({
      attract: 15,
      repulse: 6,
      Severity: Major
      Found in public/navigator/js-mindmap.js - About 4 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $('.content-field').find('.chips input').focus(function (focus_event) {
      var focused_text_field = $(focus_event.target);
      var parent_content_field = focused_text_field.closest('.content-field');

      $('.show-when-focused').hide();
        Severity: Major
        Found in app/assets/javascripts/field_focusing.js and 1 other location - About 4 hrs to fix
        app/assets/javascripts/field_focusing.js on lines 2..11

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          $('.content-field').find('textarea').focus(function (focus_event) {
    var focused_text_field = $(focus_event.target);
    var parent_content_field = focused_text_field.closest('.content-field');

    $('.show-when-focused').hide();
        Severity: Major
        Found in app/assets/javascripts/field_focusing.js and 1 other location - About 4 hrs to fix
        app/assets/javascripts/field_focusing.js on lines 16..25

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File PageLookupSidebar.js has 334 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*
  Usage:
  <%= react_component("PageLookupSidebar", {document_id: @document.id}) %>
*/
        Severity: Minor
        Found in app/javascript/components/PageLookupSidebar.js - About 4 hrs to fix

          Function fieldData has 98 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            fieldData(field) {
    switch (field.type) {
      case "name":
      case "text_area":
        // console.log(field.value);
          Severity: Major
          Found in app/javascript/components/PageLookupSidebar.js - About 3 hrs to fix

            Function getForceVector has 97 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              Node.prototype.getForceVector = function () {
    var i, x1, y1, xsign, dist, theta, f,
      xdist, rightdist, bottomdist, otherend,
      fx = 0,
      fy = 0,
            Severity: Major
            Found in public/navigator/js-mindmap.js - About 3 hrs to fix

              Method content_to_outline has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
              Open

                def content_to_outline
    content_types = current_user.content.except('Document').except('Timeline').keys

    text = ""
    content_types.each do |content_type|
              Severity: Minor
              Found in app/controllers/export_controller.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method migrate_fields_for_content has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.migrate_fields_for_content(content_model, user, force: false)
    return unless content_model.present? && user.present?
    return unless content_model.user == user
    return if content_model.is_a?(ContentPage)
    return if !force && content_model.persisted? && content_model.created_at > 'May 1, 2018'.to_datetime
              Severity: Minor
              Found in app/services/temporary_field_migration_service.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method create has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
              Open

                def create
    content_type = content_type_from_controller(self.class)
    initialize_object

    unless current_user.can_create?(content_type) \
              Severity: Minor
              Found in app/controllers/content_controller.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          result_container.append(
              $('<a />')
                .attr('href', '#')
                .addClass('field-suggestion-link chip hoverable')
                .text(value)
              Severity: Major
              Found in app/assets/javascripts/attributes_editor.js and 1 other location - About 3 hrs to fix
              app/assets/javascripts/attributes_editor.js on lines 19..29

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          result_container.append(
              $('<a />')
                .attr('href', '#')
                .addClass('category-suggestion-link chip hoverable')
                .text(value)
              Severity: Major
              Found in app/assets/javascripts/attributes_editor.js and 1 other location - About 3 hrs to fix
              app/assets/javascripts/attributes_editor.js on lines 67..77

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method commission has 87 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def commission
    @generated_images_count  = current_user.basil_commissions.with_deleted.count
    if !current_user.on_premium_plan? && @generated_images_count > BasilService::FREE_IMAGE_LIMIT
      redirect_back fallback_location: basil_path, notice: "You've reached your free image limit. Please upgrade to generate more images."
      return
              Severity: Major
              Found in app/controllers/basil_controller.rb - About 3 hrs to fix
                Severity
                Category
                Status
                Source
                Language