Sign upLogin

indr/ember-seneca-auth

View on GitHub
Star

Showing 8 of 8 total issues

Function start has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function start(done) {
  const self = this;
  done = done || noop;

  const options = require('./options') || {};
Severity: Major
Found in scripts/server.js - About 2 hrs to fix

    Function _assignFromUser has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      _assignFromUser(response, options) {
    if (options && options.assignFromUser) {
      var keys = Ember.isArray(options.assignFromUser) ? options.assignFromUser :
        (typeof options.assignFromUser === 'string' ? [options.assignFromUser] : Object.keys(response['user']));
      for (var i = 0; i < keys.length; i++) {
    Severity: Minor
    Found in addon/authenticators/seneca.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      login(identification, password, data = {}) {
    data = Utils.assign({
      username: identification,
      password: password
    }, data);
    Severity: Major
    Found in addon/services/seneca-auth.js and 1 other location - About 1 hr to fix
    addon/services/seneca-auth.js on lines 85..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      createReset(emailAddress, nick, data = {}) {
    data = Utils.assign({
      email: emailAddress,
      nick: nick
    }, data);
    Severity: Major
    Found in addon/services/seneca-auth.js and 1 other location - About 1 hr to fix
    addon/services/seneca-auth.js on lines 26..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function register has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      register(emailAddress, password, repeat, nick, name, data = {}) {
    Severity: Minor
    Found in addon/services/seneca-auth.js - About 45 mins to fix

      Function updateUser has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        updateUser(newNick, oldNick, newEmailAddress, oldEmailAddress, data) {
      Severity: Minor
      Found in addon/services/seneca-auth.js - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          server.seneca.act('role: user, cmd: register', {
    nick: 'nu1',
    name: 'u1',
    email: 'u1@example.com',
    password: 'pu1',
        Severity: Minor
        Found in scripts/server.js and 1 other location - About 35 mins to fix
        scripts/server.js on lines 107..114

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          server.seneca.act('role: user, cmd: register', {
    nick: 'nu2',
    name: 'u2',
    email: 'u2@example.com',
    password: 'pu2',
        Severity: Minor
        Found in scripts/server.js and 1 other location - About 35 mins to fix
        scripts/server.js on lines 99..106

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language