indutny/elliptic

View on GitHub

Showing 130 of 130 total issues

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    if (!this.y.red)
      this.y = this.y.toRed(this.curve.red);
Severity: Major
Found in lib/elliptic/curve/edwards.js and 9 other locations - About 30 mins to fix
lib/elliptic/curve/edwards.js on lines 127..128
lib/elliptic/curve/edwards.js on lines 131..132
lib/elliptic/curve/mont.js on lines 38..39
lib/elliptic/curve/mont.js on lines 40..41
lib/elliptic/curve/short.js on lines 265..266
lib/elliptic/curve/short.js on lines 267..268
lib/elliptic/curve/short.js on lines 501..502
lib/elliptic/curve/short.js on lines 503..504
lib/elliptic/curve/short.js on lines 505..506

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

      return false;
Severity: Major
Found in lib/elliptic/ec/signature.js - About 30 mins to fix

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (!this.x.red)
          this.x = this.x.toRed(this.curve.red);
    Severity: Major
    Found in lib/elliptic/curve/edwards.js and 9 other locations - About 30 mins to fix
    lib/elliptic/curve/edwards.js on lines 129..130
    lib/elliptic/curve/edwards.js on lines 131..132
    lib/elliptic/curve/mont.js on lines 38..39
    lib/elliptic/curve/mont.js on lines 40..41
    lib/elliptic/curve/short.js on lines 265..266
    lib/elliptic/curve/short.js on lines 267..268
    lib/elliptic/curve/short.js on lines 501..502
    lib/elliptic/curve/short.js on lines 503..504
    lib/elliptic/curve/short.js on lines 505..506

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (!this.x.red)
          this.x = this.x.toRed(this.curve.red);
    Severity: Major
    Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
    lib/elliptic/curve/edwards.js on lines 127..128
    lib/elliptic/curve/edwards.js on lines 129..130
    lib/elliptic/curve/edwards.js on lines 131..132
    lib/elliptic/curve/mont.js on lines 38..39
    lib/elliptic/curve/mont.js on lines 40..41
    lib/elliptic/curve/short.js on lines 267..268
    lib/elliptic/curve/short.js on lines 501..502
    lib/elliptic/curve/short.js on lines 503..504
    lib/elliptic/curve/short.js on lines 505..506

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

        return this.curve.point(null, null);
    Severity: Major
    Found in lib/elliptic/curve/short.js - About 30 mins to fix

      Similar blocks of code found in 10 locations. Consider refactoring.
      Open

        if (!this.y.red)
          this.y = this.y.toRed(this.curve.red);
      Severity: Major
      Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
      lib/elliptic/curve/edwards.js on lines 127..128
      lib/elliptic/curve/edwards.js on lines 129..130
      lib/elliptic/curve/edwards.js on lines 131..132
      lib/elliptic/curve/mont.js on lines 38..39
      lib/elliptic/curve/mont.js on lines 40..41
      lib/elliptic/curve/short.js on lines 265..266
      lib/elliptic/curve/short.js on lines 267..268
      lib/elliptic/curve/short.js on lines 501..502
      lib/elliptic/curve/short.js on lines 505..506

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 10 locations. Consider refactoring.
      Open

          if (!this.z.red)
            this.z = this.z.toRed(this.curve.red);
      Severity: Major
      Found in lib/elliptic/curve/edwards.js and 9 other locations - About 30 mins to fix
      lib/elliptic/curve/edwards.js on lines 127..128
      lib/elliptic/curve/edwards.js on lines 129..130
      lib/elliptic/curve/mont.js on lines 38..39
      lib/elliptic/curve/mont.js on lines 40..41
      lib/elliptic/curve/short.js on lines 265..266
      lib/elliptic/curve/short.js on lines 267..268
      lib/elliptic/curve/short.js on lines 501..502
      lib/elliptic/curve/short.js on lines 503..504
      lib/elliptic/curve/short.js on lines 505..506

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

          return false;
      Severity: Major
      Found in lib/elliptic/ec/signature.js - About 30 mins to fix

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          if (!this.x.red)
            this.x = this.x.toRed(this.curve.red);
        Severity: Major
        Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
        lib/elliptic/curve/edwards.js on lines 127..128
        lib/elliptic/curve/edwards.js on lines 129..130
        lib/elliptic/curve/edwards.js on lines 131..132
        lib/elliptic/curve/mont.js on lines 38..39
        lib/elliptic/curve/mont.js on lines 40..41
        lib/elliptic/curve/short.js on lines 265..266
        lib/elliptic/curve/short.js on lines 267..268
        lib/elliptic/curve/short.js on lines 503..504
        lib/elliptic/curve/short.js on lines 505..506

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

            if (!this.x.red)
              this.x = this.x.toRed(this.curve.red);
        Severity: Major
        Found in lib/elliptic/curve/mont.js and 9 other locations - About 30 mins to fix
        lib/elliptic/curve/edwards.js on lines 127..128
        lib/elliptic/curve/edwards.js on lines 129..130
        lib/elliptic/curve/edwards.js on lines 131..132
        lib/elliptic/curve/mont.js on lines 40..41
        lib/elliptic/curve/short.js on lines 265..266
        lib/elliptic/curve/short.js on lines 267..268
        lib/elliptic/curve/short.js on lines 501..502
        lib/elliptic/curve/short.js on lines 503..504
        lib/elliptic/curve/short.js on lines 505..506

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        KeyPair.fromSecret = function fromSecret(eddsa, secret) {
          if (secret instanceof KeyPair)
            return secret;
          return new KeyPair(eddsa, { secret: secret });
        };
        Severity: Minor
        Found in lib/elliptic/eddsa/key.js and 1 other location - About 30 mins to fix
        lib/elliptic/eddsa/key.js on lines 26..30

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

          return this.curve.jpoint(jx, jyd.redMul(tinv), jz);
        Severity: Major
        Found in lib/elliptic/curve/short.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            if (this.x.redMul(pz2).redISub(p.x.redMul(z2)).cmpn(0) !== 0)
          Severity: Minor
          Found in lib/elliptic/curve/short.js and 1 other location - About 30 mins to fix
          lib/elliptic/curve/short.js on lines 905..905

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            return this.y.redMul(pz3).redISub(p.y.redMul(z3)).cmpn(0) === 0;
          Severity: Minor
          Found in lib/elliptic/curve/short.js and 1 other location - About 30 mins to fix
          lib/elliptic/curve/short.js on lines 899..899

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

            return this.curve.jpoint(nx, ny, nz);
          Severity: Major
          Found in lib/elliptic/curve/short.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return false;
            Severity: Major
            Found in lib/elliptic/ec/signature.js - About 30 mins to fix

              Similar blocks of code found in 10 locations. Consider refactoring.
              Open

                  if (!this.z.red)
                    this.z = this.z.toRed(this.curve.red);
              Severity: Major
              Found in lib/elliptic/curve/mont.js and 9 other locations - About 30 mins to fix
              lib/elliptic/curve/edwards.js on lines 127..128
              lib/elliptic/curve/edwards.js on lines 129..130
              lib/elliptic/curve/edwards.js on lines 131..132
              lib/elliptic/curve/mont.js on lines 38..39
              lib/elliptic/curve/short.js on lines 265..266
              lib/elliptic/curve/short.js on lines 267..268
              lib/elliptic/curve/short.js on lines 501..502
              lib/elliptic/curve/short.js on lines 503..504
              lib/elliptic/curve/short.js on lines 505..506

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function eqXToP has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              JPoint.prototype.eqXToP = function eqXToP(x) {
                var zs = this.z.redSqr();
                var rx = x.toRed(this.curve.red).redMul(zs);
                if (this.x.cmp(rx) === 0)
                  return true;
              Severity: Minor
              Found in lib/elliptic/curve/short.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getKeyRecoveryParam has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              EC.prototype.getKeyRecoveryParam = function(e, signature, Q, enc) {
                signature = new Signature(signature, enc);
                if (signature.recoveryParam !== null)
                  return signature.recoveryParam;
              
              
              Severity: Minor
              Found in lib/elliptic/ec/index.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function eqXToP has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              Point.prototype.eqXToP = function eqXToP(x) {
                var rx = x.toRed(this.curve.red).redMul(this.z);
                if (this.x.cmp(rx) === 0)
                  return true;
              
              
              Severity: Minor
              Found in lib/elliptic/curve/edwards.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language