indutny/elliptic

View on GitHub

Showing 136 of 136 total issues

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    if (!this.x.red)
      this.x = this.x.toRed(this.curve.red);
Severity: Major
Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
lib/elliptic/curve/edwards.js on lines 127..128
lib/elliptic/curve/edwards.js on lines 129..130
lib/elliptic/curve/edwards.js on lines 131..132
lib/elliptic/curve/mont.js on lines 38..39
lib/elliptic/curve/mont.js on lines 40..41
lib/elliptic/curve/short.js on lines 267..268
lib/elliptic/curve/short.js on lines 501..502
lib/elliptic/curve/short.js on lines 503..504
lib/elliptic/curve/short.js on lines 505..506

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    if (!this.z.red)
      this.z = this.z.toRed(this.curve.red);
Severity: Major
Found in lib/elliptic/curve/mont.js and 9 other locations - About 30 mins to fix
lib/elliptic/curve/edwards.js on lines 127..128
lib/elliptic/curve/edwards.js on lines 129..130
lib/elliptic/curve/edwards.js on lines 131..132
lib/elliptic/curve/mont.js on lines 38..39
lib/elliptic/curve/short.js on lines 265..266
lib/elliptic/curve/short.js on lines 267..268
lib/elliptic/curve/short.js on lines 501..502
lib/elliptic/curve/short.js on lines 503..504
lib/elliptic/curve/short.js on lines 505..506

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return false;
Severity: Major
Found in lib/elliptic/ec/signature.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return this.curve.point(nx, ny);
    Severity: Major
    Found in lib/elliptic/curve/short.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return this.curve.jpoint(jx, jyd.redMul(tinv), jz);
      Severity: Major
      Found in lib/elliptic/curve/short.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          return true;
        Severity: Major
        Found in lib/elliptic/ec/signature.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return val;
          Severity: Major
          Found in lib/elliptic/ec/signature.js - About 30 mins to fix

            Similar blocks of code found in 10 locations. Consider refactoring.
            Open

                if (!this.z.red)
                  this.z = this.z.toRed(this.curve.red);
            Severity: Major
            Found in lib/elliptic/curve/edwards.js and 9 other locations - About 30 mins to fix
            lib/elliptic/curve/edwards.js on lines 127..128
            lib/elliptic/curve/edwards.js on lines 129..130
            lib/elliptic/curve/mont.js on lines 38..39
            lib/elliptic/curve/mont.js on lines 40..41
            lib/elliptic/curve/short.js on lines 265..266
            lib/elliptic/curve/short.js on lines 267..268
            lib/elliptic/curve/short.js on lines 501..502
            lib/elliptic/curve/short.js on lines 503..504
            lib/elliptic/curve/short.js on lines 505..506

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                  return false;
            Severity: Major
            Found in lib/elliptic/ec/signature.js - About 30 mins to fix

              Similar blocks of code found in 10 locations. Consider refactoring.
              Open

                if (!this.y.red)
                  this.y = this.y.toRed(this.curve.red);
              Severity: Major
              Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
              lib/elliptic/curve/edwards.js on lines 127..128
              lib/elliptic/curve/edwards.js on lines 129..130
              lib/elliptic/curve/edwards.js on lines 131..132
              lib/elliptic/curve/mont.js on lines 38..39
              lib/elliptic/curve/mont.js on lines 40..41
              lib/elliptic/curve/short.js on lines 265..266
              lib/elliptic/curve/short.js on lines 267..268
              lib/elliptic/curve/short.js on lines 501..502
              lib/elliptic/curve/short.js on lines 505..506

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                return this.y.redMul(pz3).redISub(p.y.redMul(z3)).cmpn(0) === 0;
              Severity: Minor
              Found in lib/elliptic/curve/short.js and 1 other location - About 30 mins to fix
              lib/elliptic/curve/short.js on lines 899..899

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 10 locations. Consider refactoring.
              Open

                  if (!this.x.red)
                    this.x = this.x.toRed(this.curve.red);
              Severity: Major
              Found in lib/elliptic/curve/mont.js and 9 other locations - About 30 mins to fix
              lib/elliptic/curve/edwards.js on lines 127..128
              lib/elliptic/curve/edwards.js on lines 129..130
              lib/elliptic/curve/edwards.js on lines 131..132
              lib/elliptic/curve/mont.js on lines 40..41
              lib/elliptic/curve/short.js on lines 265..266
              lib/elliptic/curve/short.js on lines 267..268
              lib/elliptic/curve/short.js on lines 501..502
              lib/elliptic/curve/short.js on lines 503..504
              lib/elliptic/curve/short.js on lines 505..506

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                  return false;
              Severity: Major
              Found in lib/elliptic/ec/signature.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                KeyPair.fromSecret = function fromSecret(eddsa, secret) {
                  if (secret instanceof KeyPair)
                    return secret;
                  return new KeyPair(eddsa, { secret: secret });
                };
                Severity: Minor
                Found in lib/elliptic/eddsa/key.js and 1 other location - About 30 mins to fix
                lib/elliptic/eddsa/key.js on lines 26..30

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this function.
                Open

                  return p.eqXToP(r);
                Severity: Major
                Found in lib/elliptic/ec/index.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return this.curve.jpoint(nx, ny, nz);
                  Severity: Major
                  Found in lib/elliptic/curve/short.js - About 30 mins to fix

                    Similar blocks of code found in 10 locations. Consider refactoring.
                    Open

                        if (!this.y.red)
                          this.y = this.y.toRed(this.curve.red);
                    Severity: Major
                    Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
                    lib/elliptic/curve/edwards.js on lines 127..128
                    lib/elliptic/curve/edwards.js on lines 129..130
                    lib/elliptic/curve/edwards.js on lines 131..132
                    lib/elliptic/curve/mont.js on lines 38..39
                    lib/elliptic/curve/mont.js on lines 40..41
                    lib/elliptic/curve/short.js on lines 265..266
                    lib/elliptic/curve/short.js on lines 501..502
                    lib/elliptic/curve/short.js on lines 503..504
                    lib/elliptic/curve/short.js on lines 505..506

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 10 locations. Consider refactoring.
                    Open

                      if (!this.z.red)
                        this.z = this.z.toRed(this.curve.red);
                    Severity: Major
                    Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
                    lib/elliptic/curve/edwards.js on lines 127..128
                    lib/elliptic/curve/edwards.js on lines 129..130
                    lib/elliptic/curve/edwards.js on lines 131..132
                    lib/elliptic/curve/mont.js on lines 38..39
                    lib/elliptic/curve/mont.js on lines 40..41
                    lib/elliptic/curve/short.js on lines 265..266
                    lib/elliptic/curve/short.js on lines 267..268
                    lib/elliptic/curve/short.js on lines 501..502
                    lib/elliptic/curve/short.js on lines 503..504

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    KeyPair.fromPublic = function fromPublic(eddsa, pub) {
                      if (pub instanceof KeyPair)
                        return pub;
                      return new KeyPair(eddsa, { pub: pub });
                    };
                    Severity: Minor
                    Found in lib/elliptic/eddsa/key.js and 1 other location - About 30 mins to fix
                    lib/elliptic/eddsa/key.js on lines 32..36

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid too many return statements within this function.
                    Open

                        return false;
                    Severity: Major
                    Found in lib/elliptic/ec/signature.js - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language