Sign upLogin

inertia186/drotto

View on GitHub
Star

Showing 29 of 31 total issues

Method can_vote? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def can_vote?(comment)
      return false if comment.nil?
      return false if voted?(comment)
      return false if comment.author == ''
      return false if blacklist.include? comment.author
Severity: Minor
Found in lib/drotto/chain.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method too_old? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def too_old?(comment, options = {use_cashout_time: false})
      return false if comment.nil?
      
      use_cashout_time = options[:use_cashout_time] || false
      cashout_time = Time.parse(comment.cashout_time + 'Z')
Severity: Minor
Found in lib/drotto/chain.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return false
Severity: Major
Found in lib/drotto/bounce_job.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return false
    Severity: Major
    Found in lib/drotto/chain.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return false
      Severity: Major
      Found in lib/drotto/bounce_job.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                  return false
        Severity: Major
        Found in lib/drotto/bounce_job.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return false
          Severity: Major
          Found in lib/drotto/bounce_job.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return false
            Severity: Major
            Found in lib/drotto/bounce_job.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return false unless comment.allow_votes
              Severity: Major
              Found in lib/drotto/chain.rb - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language