Sign upLogin

inertia186/obarc

View on GitHub
Star

Showing 36 of 36 total issues

Function linkList has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function linkList() {
  $('#full_list li, #full_list li a:last').click(function(evt) {
    if ($(this).hasClass('toggle')) return true;
    if (this.tagName.toLowerCase() == "li") {
      if ($(this).find('.object_link a').length === 0) {
Severity: Minor
Found in doc/js/full_list.js - About 1 hr to fix

    Method upload_contract_images_with has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def upload_contract_images_with(symbol, contract = {})
      contract[:images] = [contract.delete(symbol)].flatten.map do |image|
        response = if image.size < 2000 && image =~ URI::ABS_URI
          upload_image(image: open(image, 'rb'))
        else
    Severity: Minor
    Found in lib/obarc/session.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(options = {})
      OPTIONS_KEYS.each do |k|
        value = if options.key?(k)
          options[k]
        else
    Severity: Minor
    Found in lib/obarc/session.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    end at 81, 8 is not aligned with if at 77, 13.
    Open

            end
    Severity: Minor
    Found in lib/obarc/api.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad

variable = if true
    end

# good

variable = if true
           end

    Example: EnforcedStyleAlignWith: variable

    # bad

variable = if true
    end

# good

variable = if true
end

    Example: EnforcedStyleAlignWith: startofline

    # bad

variable = if true
    end

# good

puts(if true
end)

    Unused method argument - include_private. If it's necessary, use _ or _include_private as an argument name to indicate that it won't be used.
    Open

        def respond_to_missing?(m, include_private = false)
    Severity: Minor
    Found in lib/obarc/api.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

    Example:

    # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

    end at 13, 2 is not aligned with if at 9, 17.
    Open

      end
    Severity: Minor
    Found in Rakefile by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad

variable = if true
    end

# good

variable = if true
           end

    Example: EnforcedStyleAlignWith: variable

    # bad

variable = if true
    end

# good

variable = if true
end

    Example: EnforcedStyleAlignWith: startofline

    # bad

variable = if true
    end

# good

puts(if true
end)

    Unused block argument - v. If it's necessary, use _ or _v as an argument name to indicate that it won't be used.
    Open

          options = options.delete_if { |k, v| elements.include? k }
    Severity: Minor
    Found in lib/obarc/api.rb by rubocop

    This cop checks for unused block arguments.

    Example:

    # bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

    Example:

    #good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

    end at 125, 6 is not aligned with if at 120, 25.
    Open

          end
    Severity: Minor
    Found in lib/obarc/session.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad

variable = if true
    end

# good

variable = if true
           end

    Example: EnforcedStyleAlignWith: variable

    # bad

variable = if true
    end

# good

variable = if true
end

    Example: EnforcedStyleAlignWith: startofline

    # bad

variable = if true
    end

# good

puts(if true
end)

    end at 83, 6 is not aligned with case at 61, 47.
    Open

          end
    Severity: Minor
    Found in lib/obarc/api.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad

variable = if true
    end

# good

variable = if true
           end

    Example: EnforcedStyleAlignWith: variable

    # bad

variable = if true
    end

# good

variable = if true
end

    Example: EnforcedStyleAlignWith: startofline

    # bad

variable = if true
    end

# good

puts(if true
end)

    end at 277, 8 is not aligned with if at 273, 19.
    Open

            end
    Severity: Minor
    Found in lib/obarc/session.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad

variable = if true
    end

# good

variable = if true
           end

    Example: EnforcedStyleAlignWith: variable

    # bad

variable = if true
    end

# good

variable = if true
end

    Example: EnforcedStyleAlignWith: startofline

    # bad

variable = if true
    end

# good

puts(if true
end)

    end at 27, 8 is not aligned with if at 23, 16.
    Open

            end
    Severity: Minor
    Found in lib/obarc/session.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad

variable = if true
    end

# good

variable = if true
           end

    Example: EnforcedStyleAlignWith: variable

    # bad

variable = if true
    end

# good

variable = if true
end

    Example: EnforcedStyleAlignWith: startofline

    # bad

variable = if true
    end

# good

puts(if true
end)

    FIXME found
    Open

    <p>start [FIXME] the starting point in the message list</p>
    Severity: Minor
    Found in doc/OBarc/Session.html by fixme

    FIXME found
    Open

            <span class='name'>FIXME</span>
    Severity: Minor
    Found in doc/OBarc/Session.html by fixme

    FIXME found
    Open

        # @param FIXME not yet supported, future: limit-[number of most recent notifications]
    Severity: Minor
    Found in lib/obarc/session.rb by fixme

    FIXME found
    Open

        #   * start [FIXME] the starting point in the message list
    Severity: Minor
    Found in lib/obarc/session.rb by fixme

    FIXME found
    Open

                  # FIXME Might want to warn that we are possibly mixing multipart
    Severity: Minor
    Found in lib/obarc/api.rb by fixme
    Severity
    Category
    Status
    Source
    Language