inertia186/radiator

View on GitHub

Showing 1,476 of 1,476 total issues

Freeze mutable objects assigned to constants.
Open

    NETWORKS_STEEM_CHAIN_ID = '0000000000000000000000000000000000000000000000000000000000000000'
Severity: Minor
Found in lib/radiator/chain_config.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Avoid the use of double negation (!!).
Open

          raise ChainError, ErrorParser.new(err) if !!err
Severity: Minor
Found in lib/radiator/chain.rb by rubocop

This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

Example:

# bad
!!something

# good
!something.nil?

Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      raise ChainError, "Required option: chain" if @chain.nil?
Severity: Minor
Found in lib/radiator/chain.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Replace class var @@logger with a class instance var.
Open

    @@logger = logger
Severity: Minor
Found in lib/radiator/logger.rb by rubocop

This cop checks for uses of class variables. Offenses are signaled only on assignment to class variables to reduce the number of offenses that would be reported.

Trailing whitespace detected.
Open

      
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

Trailing whitespace detected.
Open

    
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

Trailing whitespace detected.
Open

    
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

Missing top-level module documentation comment.
Open

  module Utils
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Trailing whitespace detected.
Open

    
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

Use snake_case for method names.
Open

    def pakArr(a)
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Use snake_case for method names.
Open

    def pakI(i)
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if %w(DEBUG TRACE).include? ENV['LOG']
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

%w-literals should be delimited by [ and ].
Open

      if %w(DEBUG TRACE).include? ENV['LOG']
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Line is too long. [95/80]
Open

    NETWORKS_HIVE_CHAIN_ID = 'beeab0de00000000000000000000000000000000000000000000000000000000'
Severity: Minor
Found in lib/radiator/chain_config.rb by rubocop

Line is too long. [95/80]
Open

    NETWORKS_TEST_CHAIN_ID = '18dcf0a285365fc58b71f18b3d3fec954aa0c141c44e4e5cb4cf777b9eab274e'
Severity: Minor
Found in lib/radiator/chain_config.rb by rubocop

Avoid the use of double negation (!!).
Open

      if !!response.result
Severity: Minor
Found in lib/radiator/chain.rb by rubocop

This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

Example:

# bad
!!something

# good
!something.nil?

Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

Trailing whitespace detected.
Open

      
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

Avoid using rescue in its modifier form.
Open

          tx[:signatures] rescue nil
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

This cop checks for uses of rescue in its modifier form.

Example:

# bad
some_method rescue handle_error

# good
begin
  some_method
rescue
  handle_error
end

Avoid using rescue in its modifier form.
Open

          Time.parse(tx[:expiration] + 'Z') rescue nil
Severity: Minor
Found in lib/radiator/utils.rb by rubocop

This cop checks for uses of rescue in its modifier form.

Example:

# bad
some_method rescue handle_error

# good
begin
  some_method
rescue
  handle_error
end

Trailing whitespace detected.
Open

    
Severity: Minor
Found in lib/radiator/chain_config.rb by rubocop
Severity
Category
Status
Source
Language