inertia186/radiator

View on GitHub
lib/radiator/error_parser.rb

Summary

Maintainability
C
1 day
Test Coverage

Class has too many lines. [178/100]
Open

  class ErrorParser
    include Utils
    
    attr_reader :response, :error, :error_code, :error_message,
      :api_name, :api_method, :api_params,
Severity: Minor
Found in lib/radiator/error_parser.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [98/10]
Open

    def parse_error_response
      if response.nil?
        @expiry = false
        @can_retry = false
        @can_reprepare = false
Severity: Minor
Found in lib/radiator/error_parser.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for parse_error_response is too high. [91.95/15]
Open

    def parse_error_response
      if response.nil?
        @expiry = false
        @can_retry = false
        @can_reprepare = false
Severity: Minor
Found in lib/radiator/error_parser.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method parse_error_response has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    def parse_error_response
      if response.nil?
        @expiry = false
        @can_retry = false
        @can_reprepare = false
Severity: Minor
Found in lib/radiator/error_parser.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_error_response has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def parse_error_response
      if response.nil?
        @expiry = false
        @can_retry = false
        @can_reprepare = false
Severity: Major
Found in lib/radiator/error_parser.rb - About 3 hrs to fix

    Cyclomatic complexity for parse_error_response is too high. [23/6]
    Open

        def parse_error_response
          if response.nil?
            @expiry = false
            @can_retry = false
            @can_reprepare = false
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Perceived complexity for parse_error_response is too high. [22/7]
    Open

        def parse_error_response
          if response.nil?
            @expiry = false
            @can_retry = false
            @can_reprepare = false
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

    Example:

    def my_method                   # 1
      if cond                       # 1
        case var                    # 2 (0.8 + 4 * 0.2, rounded)
        when 1 then func_one
        when 2 then func_two
        when 3 then func_three
        when 4..10 then func_other
        end
      else                          # 1
        do_something until a && b   # 2
      end                           # ===
    end                             # 7 complexity points

    Method has too many lines. [20/10]
    Open

        def coerce_backtrace
          can_retry = false
          
          case @error['code']
          when -32003
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method has too many lines. [15/10]
    Open

        def error_match?(matches)
          matches = [matches].flatten
          
          any = matches.map do |match|
            case match
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method has too many lines. [13/10]
    Open

        def initialize(response)
          @response = response
          
          @error = nil
          @error_code = nil
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method error_match? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def error_match?(matches)
          matches = [matches].flatten
          
          any = matches.map do |match|
            case match
    Severity: Minor
    Found in lib/radiator/error_parser.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Align else with if.
    Open

              else
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cops checks the alignment of else keywords. Normally they should be aligned with an if/unless/while/until/begin/def keyword, but there are special cases when they should follow the same rules as the alignment of end.

    Example:

    # bad
    if something
      code
     else
      code
    end
    
    # bad
    if something
      code
     elsif something
      code
    end
    
    # good
    if something
      code
    else
      code
    end

    Trailing whitespace detected.
    Open

          
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

          
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

          
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

            
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

              
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

                
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

            
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Align else with if.
    Open

          else
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cops checks the alignment of else keywords. Normally they should be aligned with an if/unless/while/until/begin/def keyword, but there are special cases when they should follow the same rules as the alignment of end.

    Example:

    # bad
    if something
      code
     else
      code
    end
    
    # bad
    if something
      code
     elsif something
      code
    end
    
    # good
    if something
      code
    else
      code
    end

    Trailing whitespace detected.
    Open

              
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Align the parameters of a method call if they span more than one line.
    Open

          :expiry, :can_retry, :can_reprepare, :node_degraded, :trx_id, :debug
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Here we check if the parameters on a multi-line method call or definition are aligned.

    Example: EnforcedStyle: withfirstparameter (default)

    # good
    
    foo :bar,
        :baz
    
    # bad
    
    foo :bar,
      :baz

    Example: EnforcedStyle: withfixedindentation

    # good
    
    foo :bar,
      :baz
    
    # bad
    
    foo :bar,
        :baz

    Trailing whitespace detected.
    Open

        
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

        
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Use 2 (not -36) spaces for indentation.
    Open

                @api_name = data_call_method['call.params']
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
    class A
     def test
      puts 'hello'
     end
    end
    
    # good
    class A
      def test
        puts 'hello'
      end
    end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
    module A
    class B
      def test
      puts 'hello'
      end
    end
    end
    
    # good
    module A
    class B
      def test
        puts 'hello'
      end
    end
    end

    Use 2 (not -7) spaces for indentation.
    Open

            response['error']
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
    class A
     def test
      puts 'hello'
     end
    end
    
    # good
    class A
      def test
        puts 'hello'
      end
    end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
    module A
    class B
      def test
      puts 'hello'
      end
    end
    end
    
    # good
    module A
    class B
      def test
        puts 'hello'
      end
    end
    end

    Trailing whitespace detected.
    Open

        
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

              
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Use 2 (not -15) spaces for indentation.
    Open

                stack_formats = stacks.map { |s| s['format'] }
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
    class A
     def test
      puts 'hello'
     end
    end
    
    # good
    class A
      def test
        puts 'hello'
      end
    end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
    module A
    class B
      def test
      puts 'hello'
      end
    end
    end
    
    # good
    module A
    class B
      def test
        puts 'hello'
      end
    end
    end

    Trailing whitespace detected.
    Open

          
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

                
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

            
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

              
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

            
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Align else with if.
    Open

              else
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cops checks the alignment of else keywords. Normally they should be aligned with an if/unless/while/until/begin/def keyword, but there are special cases when they should follow the same rules as the alignment of end.

    Example:

    # bad
    if something
      code
     else
      code
    end
    
    # bad
    if something
      code
     elsif something
      code
    end
    
    # good
    if something
      code
    else
      code
    end

    Trailing whitespace detected.
    Open

              
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

              
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

          
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

            
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    end at 57, 6 is not aligned with if at 53, 15.
    Open

          end
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
               end

    Example: EnforcedStyleAlignWith: variable

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
    end

    Example: EnforcedStyleAlignWith: startofline

    # bad
    
    variable = if true
        end
    
    # good
    
    puts(if true
    end)

    Use underscores(_) as decimal mark and separate every 3 digits with them.
    Open

            when -32003
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for big numeric literals without _ between groups of digits in them.

    Example:

    # bad
    
    1000000
    1_00_000
    1_0000
    
    # good
    
    1_000_000
    1000
    
    # good unless Strict is set
    
    10_000_00 # typical representation of $10,000 in cents

    Use underscores(_) as decimal mark and separate every 3 digits with them.
    Open

            when 4030200
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for big numeric literals without _ between groups of digits in them.

    Example:

    # bad
    
    1000000
    1_00_000
    1_0000
    
    # good
    
    1_000_000
    1000
    
    # good unless Strict is set
    
    10_000_00 # typical representation of $10,000 in cents

    Align the parameters of a method call if they span more than one line.
    Open

          :api_name, :api_method, :api_params,
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Here we check if the parameters on a multi-line method call or definition are aligned.

    Example: EnforcedStyle: withfirstparameter (default)

    # good
    
    foo :bar,
        :baz
    
    # bad
    
    foo :bar,
      :baz

    Example: EnforcedStyle: withfixedindentation

    # good
    
    foo :bar,
      :baz
    
    # bad
    
    foo :bar,
        :baz

    Trailing whitespace detected.
    Open

          
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    end at 86, 10 is not aligned with if at 84, 48.
    Open

              end
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
               end

    Example: EnforcedStyleAlignWith: variable

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
    end

    Example: EnforcedStyleAlignWith: startofline

    # bad
    
    variable = if true
        end
    
    # good
    
    puts(if true
    end)

    Trailing whitespace detected.
    Open

        
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

          
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

        
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    end at 82, 10 is not aligned with if at 68, 27.
    Open

              end
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
               end

    Example: EnforcedStyleAlignWith: variable

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
    end

    Example: EnforcedStyleAlignWith: startofline

    # bad
    
    variable = if true
        end
    
    # good
    
    puts(if true
    end)

    Trailing whitespace detected.
    Open

        
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Line is too long. [88/80]
    Open

              @can_reprepare = !!stack_formats && (stack_formats & REPREPARE_WHITELIST).any?
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

            
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Missing top-level class documentation comment.
    Open

      class ErrorParser
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

    The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

    Example:

    # bad
    class Person
      # ...
    end
    
    # good
    # Description/Explanation of Person class
    class Person
      # ...
    end

    Avoid the use of double negation (!!).
    Open

                @trx_id = data_trx_ix['trx_ix'] if !!data_trx_ix
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

    Example:

    # bad
    !!something
    
    # good
    !something.nil?

    Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

    Use 2 (not -15) spaces for indentation.
    Open

                error_match(REPREPARE_WHITELIST)
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
    class A
     def test
      puts 'hello'
     end
    end
    
    # good
    class A
      def test
        puts 'hello'
      end
    end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
    module A
    class B
      def test
      puts 'hello'
      end
    end
    end
    
    # good
    module A
    class B
      def test
        puts 'hello'
      end
    end
    end

    Trailing whitespace detected.
    Open

          
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

          
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Avoid the use of double negation (!!).
    Open

          if !!error_message && !error_message.empty?
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

    Example:

    # bad
    !!something
    
    # good
    !something.nil?

    Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

    Avoid rescuing without specifying an error class.
    Open

          rescue => e
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

    Example: EnforcedStyle: implicit

    # `implicit` will enforce using `rescue` instead of
    # `rescue StandardError`.
    
    # bad
    begin
      foo
    rescue StandardError
      bar
    end
    
    # good
    begin
      foo
    rescue
      bar
    end
    
    # good
    begin
      foo
    rescue OtherError
      bar
    end
    
    # good
    begin
      foo
    rescue StandardError, SecurityError
      bar
    end

    Example: EnforcedStyle: explicit (default)

    # `explicit` will enforce using `rescue StandardError`
    # instead of `rescue`.
    
    # bad
    begin
      foo
    rescue
      bar
    end
    
    # good
    begin
      foo
    rescue StandardError
      bar
    end
    
    # good
    begin
      foo
    rescue OtherError
      bar
    end
    
    # good
    begin
      foo
    rescue StandardError, SecurityError
      bar
    end

    Trailing whitespace detected.
    Open

        
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Avoid the use of double negation (!!).
    Open

                data_trx_ix = stack_datum.find { |data| !!data['trx_ix'] }
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

    Example:

    # bad
    !!something
    
    # good
    !something.nil?

    Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

    Avoid the use of double negation (!!).
    Open

              @api_name, @api_method, @api_params = if !!data_call_method
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

    Example:

    # bad
    !!something
    
    # good
    !something.nil?

    Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

    Use underscores(_) as decimal mark and separate every 3 digits with them.
    Open

          when -32002
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for big numeric literals without _ between groups of digits in them.

    Example:

    # bad
    
    1000000
    1_00_000
    1_0000
    
    # good
    
    1_000_000
    1000
    
    # good unless Strict is set
    
    10_000_00 # typical representation of $10,000 in cents

    Avoid the use of double negation (!!).
    Open

          @error = if !!@response['error']
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

    Example:

    # bad
    !!something
    
    # good
    !something.nil?

    Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

    Trailing whitespace detected.
    Open

        
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Line is too long. [88/80]
    Open

                data_call_method = stack_datum.find { |data| data['call.method'] == 'call' }
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Trailing whitespace detected.
    Open

        
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Line is too long. [185/80]
    Open

        DUPECHECK = '(skip & skip_transaction_dupe_check) || trx_idx.indices().get<by_trx_id>().find(trx_id) == trx_idx.indices().get<by_trx_id>().end(): Duplicate transaction check failed'
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Avoid the use of double negation (!!).
    Open

              @error_message = if !!stacks
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

    Example:

    # bad
    !!something
    
    # good
    !something.nil?

    Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

    Avoid the use of double negation (!!).
    Open

              @can_reprepare = !!stack_formats && (stack_formats & REPREPARE_WHITELIST).any?
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

    Example:

    # bad
    !!something
    
    # good
    !something.nil?

    Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

    Use underscores(_) as decimal mark and separate every 3 digits with them.
    Open

            when 3030000
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for big numeric literals without _ between groups of digits in them.

    Example:

    # bad
    
    1000000
    1_00_000
    1_0000
    
    # good
    
    1_000_000
    1000
    
    # good unless Strict is set
    
    10_000_00 # typical representation of $10,000 in cents

    Trailing whitespace detected.
    Open

          
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Line is too long. [88/80]
    Open

            can_retry = @node_degraded = error_match?('no method with name \'condenser_api')
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    Avoid the use of double negation (!!).
    Open

            if !!@error['data']
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

    Example:

    # bad
    !!something
    
    # good
    !something.nil?

    Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

    Freeze mutable objects assigned to constants.
    Open

        REPREPARE_BLACKLIST = [DUPECHECK]
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

    Example:

    # bad
    CONST = [1, 2, 3]
    
    # good
    CONST = [1, 2, 3].freeze

    Use underscores(_) as decimal mark and separate every 3 digits with them.
    Open

            when 4030100
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for big numeric literals without _ between groups of digits in them.

    Example:

    # bad
    
    1000000
    1_00_000
    1_0000
    
    # good
    
    1_000_000
    1000
    
    # good unless Strict is set
    
    10_000_00 # typical representation of $10,000 in cents

    Freeze mutable objects assigned to constants.
    Open

        DUPECHECK = '(skip & skip_transaction_dupe_check) || trx_idx.indices().get<by_trx_id>().find(trx_id) == trx_idx.indices().get<by_trx_id>().end(): Duplicate transaction check failed'
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

    Example:

    # bad
    CONST = [1, 2, 3]
    
    # good
    CONST = [1, 2, 3].freeze

    end at 115, 10 is not aligned with if at 111, 27.
    Open

              end
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
               end

    Example: EnforcedStyleAlignWith: variable

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
    end

    Example: EnforcedStyleAlignWith: startofline

    # bad
    
    variable = if true
        end
    
    # good
    
    puts(if true
    end)

    Use self instead of Object#to_s in interpolation.
    Open

          "#<#{self.class.name} [#{to_s}]>"
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for string conversion in string interpolation, which is redundant.

    Example:

    # bad
    
    "result is #{something.to_s}"

    Example:

    # good
    
    "result is #{something}"

    Use underscores(_) as decimal mark and separate every 3 digits with them.
    Open

            when -32603
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for big numeric literals without _ between groups of digits in them.

    Example:

    # bad
    
    1000000
    1_00_000
    1_0000
    
    # good
    
    1_000_000
    1000
    
    # good unless Strict is set
    
    10_000_00 # typical representation of $10,000 in cents

    Freeze mutable objects assigned to constants.
    Open

        REPREPARE_WHITELIST = [
          'is_canonical( c ): signature is not canonical',
          'now < trx.expiration: '
        ]
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

    Example:

    # bad
    CONST = [1, 2, 3]
    
    # good
    CONST = [1, 2, 3].freeze

    Use underscores(_) as decimal mark and separate every 3 digits with them.
    Open

            when -32000
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for big numeric literals without _ between groups of digits in them.

    Example:

    # bad
    
    1000000
    1_00_000
    1_0000
    
    # good
    
    1_000_000
    1000
    
    # good unless Strict is set
    
    10_000_00 # typical representation of $10,000 in cents

    Use underscores(_) as decimal mark and separate every 3 digits with them.
    Open

          when -32003
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    This cop checks for big numeric literals without _ between groups of digits in them.

    Example:

    # bad
    
    1000000
    1_00_000
    1_0000
    
    # good
    
    1_000_000
    1000
    
    # good unless Strict is set
    
    10_000_00 # typical representation of $10,000 in cents

    Line is too long. [93/80]
    Open

                ap error_parser_exception: e, original_response: response, backtrace: e.backtrace
    Severity: Minor
    Found in lib/radiator/error_parser.rb by rubocop

    There are no issues that match your filters.

    Category
    Status