Sign upLogin

inertia186/radiator

View on GitHub
Star
lib/radiator/operation_types.rb

Summary

Maintainability
A
35 mins
Test Coverage

Module has too many lines. [146/100]
Open

  module OperationTypes
    TYPES = {
      transfer: {
        amount: Hive::Type::Amount
      },
Severity: Minor
Found in lib/radiator/operation_types.rb by rubocop

This cop checks if the length a module exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [12/10]
Open

    def type(chain, key, param, value)
      return if value.nil?
      
      t = TYPES[key] or return value
      p = t[param] or return value
Severity: Minor
Found in lib/radiator/operation_types.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method type has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def type(chain, key, param, value)
      return if value.nil?
      
      t = TYPES[key] or return value
      p = t[param] or return value
Severity: Minor
Found in lib/radiator/operation_types.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Freeze mutable objects assigned to constants.
Open

    TYPES = {
      transfer: {
        amount: Hive::Type::Amount
      },
      transfer_to_vesting: {
Severity: Minor
Found in lib/radiator/operation_types.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Trailing whitespace detected.
Open
Severity: Minor
Found in lib/radiator/operation_types.rb by rubocop

Trailing whitespace detected.
Open
Severity: Minor
Found in lib/radiator/operation_types.rb by rubocop

Use || instead of or.
Open

      p = t[param] or return value
Severity: Minor
Found in lib/radiator/operation_types.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Trailing whitespace detected.
Open
Severity: Minor
Found in lib/radiator/operation_types.rb by rubocop

Use || instead of or.
Open

      t = TYPES[key] or return value
Severity: Minor
Found in lib/radiator/operation_types.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Trailing whitespace detected.
Open
Severity: Minor
Found in lib/radiator/operation_types.rb by rubocop

There are no issues that match your filters.

Category
Status