Sign upLogin

influxdata/influxdb-java

View on GitHub
Star

Showing 114 of 114 total issues

BatchOptions has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

public final class BatchOptions implements Cloneable {

  // default values here are consistent with Telegraf
  public static final int DEFAULT_BATCH_ACTIONS_LIMIT = 1000;
  public static final int DEFAULT_BATCH_INTERVAL_DURATION = 1000;
Severity: Minor
Found in src/main/java/org/influxdb/BatchOptions.java - About 2 hrs to fix

    BatchPoints has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class BatchPoints {
  private String database;
  private String retentionPolicy;
  private Map<String, String> tags;
  private List<Point> points;
    Severity: Minor
    Found in src/main/java/org/influxdb/dto/BatchPoints.java - About 2 hrs to fix

      Method buildQueryString has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        @Override
  public StringBuilder buildQueryString(final StringBuilder builder) {
    builder.append("SELECT ");

    if (isDistinct) {
      Severity: Major
      Found in src/main/java/org/influxdb/querybuilder/SelectCoreImpl.java - About 2 hrs to fix

        Method appendName has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          public static StringBuilder appendName(final Object name, final StringBuilder stringBuilder) {
    if (name instanceof String) {
      appendName((String) name, stringBuilder);
    } else if (name instanceof Column) {
      appendName(((Column) name).getName(), stringBuilder);
        Severity: Minor
        Found in src/main/java/org/influxdb/querybuilder/Appender.java - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method setField has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            private void setField(
            final Class<?> fieldType,
            final String columnName,
            final Object value) {
      if (boolean.class.isAssignableFrom(fieldType) || Boolean.class.isAssignableFrom(fieldType)) {
        Severity: Minor
        Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method write has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          void write() {
    List<Point> currentBatch = null;
    try {
      if (this.queue.isEmpty()) {
        BatchProcessor.this.batchWriter.write(Collections.emptyList());
        Severity: Minor
        Found in src/main/java/org/influxdb/impl/BatchProcessor.java - About 1 hr to fix

          Method concatenatedFields has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

            private int concatenatedFields(final StringBuilder sb) {
    int fieldCount = 0;
    for (Entry<String, Object> field : this.fields.entrySet()) {
      Object value = field.getValue();
      if (value == null || isNotFinite(value)) {
          Severity: Minor
          Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method adaptValue has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            private static Object adaptValue(final Class<?> fieldType, final Object value, final TimeUnit precision,
                                   final String fieldName, final String className) {
    try {
      if (String.class.isAssignableFrom(fieldType)) {
        return String.valueOf(value);
          Severity: Minor
          Found in src/main/java/org/influxdb/impl/InfluxDBResultMapper.java - About 1 hr to fix

            Method equals has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

              @SuppressWarnings("checkstyle:needbraces")
  @Override
  public boolean equals(final Object obj) {
    if (this == obj)
      return true;
            Severity: Minor
            Found in src/main/java/org/influxdb/dto/Query.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method addFieldsFromPOJO has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public Builder addFieldsFromPOJO(final Object pojo) {

      Class<?> clazz = pojo.getClass();
      Measurement measurement = clazz.getAnnotation(Measurement.class);
      boolean allFields = measurement != null && measurement.allFields();
            Severity: Minor
            Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

              Method addFieldByAttribute has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private void addFieldByAttribute(final Object pojo, final Field field, final boolean tag,
                                     final String fieldName, final TypeMapper typeMapper) {
      try {
        Object fieldValue = field.get(pojo);
              Severity: Minor
              Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

                Method appendValue has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                  public static StringBuilder appendValue(final Object value, final StringBuilder stringBuilder) {
    if (value instanceof Appendable) {
      Appendable appendable = (Appendable) value;
      appendable.appendTo(stringBuilder);
    } else if (value instanceof Function) {
                Severity: Minor
                Found in src/main/java/org/influxdb/querybuilder/Appender.java - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method write has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  @Override
  public synchronized void write(final Collection<BatchPoints> collection) {
    // empty the cached data first
    ListIterator<BatchPoints> batchQueueIterator = batchQueue.listIterator();
    while (batchQueueIterator.hasNext()) {
                Severity: Minor
                Found in src/main/java/org/influxdb/impl/RetryCapableBatchWriter.java - About 1 hr to fix

                  Method cacheMeasurementClass has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    void cacheMeasurementClass(final Class<?>... classVarAgrs) {
    for (Class<?> clazz : classVarAgrs) {
      if (CLASS_INFO_CACHE.containsKey(clazz.getName())) {
        continue;
      }
                  Severity: Minor
                  Found in src/main/java/org/influxdb/impl/InfluxDBResultMapper.java - About 1 hr to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        } else if (name instanceof Function) {
      Function functionCall = (Function) name;
      stringBuilder.append(functionCall.getName()).append('(');
      for (int i = 0; i < functionCall.getParameters().length; i++) {
        if (i > 0) {
                    Severity: Major
                    Found in src/main/java/org/influxdb/querybuilder/Appender.java and 1 other location - About 1 hr to fix
                    src/main/java/org/influxdb/querybuilder/Appender.java on lines 53..63

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 90.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        } else if (value instanceof Function) {
      Function functionCall = (Function) value;
      stringBuilder.append(functionCall.getName()).append('(');
      for (int i = 0; i < functionCall.getParameters().length; i++) {
        if (i > 0) {
                    Severity: Major
                    Found in src/main/java/org/influxdb/querybuilder/Appender.java and 1 other location - About 1 hr to fix
                    src/main/java/org/influxdb/querybuilder/Appender.java on lines 91..101

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 90.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method formatedTime has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                      private void formatedTime(final StringBuilder sb, final TimeUnit precision) {
    if (this.time == null) {
      return;
    }
    TimeUnit converterPrecision = precision;
                    Severity: Minor
                    Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method parseSeriesAs has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      <T> List<T> parseSeriesAs(final QueryResult.Series series, final Class<T> clazz, final List<T> result,
                            final TimeUnit precision) {
    int columnSize = series.getColumns().size();

    ClassInfo classInfo = CLASS_INFO_CACHE.get(clazz.getName());
                    Severity: Minor
                    Found in src/main/java/org/influxdb/impl/InfluxDBResultMapper.java - About 1 hr to fix

                      Method formatedTime has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        private void formatedTime(final StringBuilder sb, final TimeUnit precision) {
    if (this.time == null) {
      return;
    }
    TimeUnit converterPrecision = precision;
                      Severity: Minor
                      Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

                        Method query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          @Override
  public void query(final Query query, final Consumer<QueryResult> onSuccess, final Consumer<Throwable> onFailure) {
    final Call<QueryResult> call = callQuery(query);
    call.enqueue(new Callback<QueryResult>() {
      @Override
                        Severity: Minor
                        Found in src/main/java/org/influxdb/impl/InfluxDBImpl.java - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language