influxdata/influxdb-java

View on GitHub

Showing 114 of 114 total issues

Method put has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  void put(final AbstractBatchEntry batchEntry) {
    try {
        if (this.dropActionsOnQueueExhaustion) {
          if (!this.queue.offer(batchEntry)) {
            this.droppedActionHandler.accept(batchEntry.getPoint());
Severity: Minor
Found in src/main/java/org/influxdb/impl/BatchProcessor.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method field has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @SuppressWarnings("checkstyle:finalparameters")
    @Deprecated
    public Builder field(final String field, Object value) {
      if (value instanceof Number) {
        if (value instanceof Byte) {
Severity: Minor
Found in src/main/java/org/influxdb/dto/Point.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        if (queryResultPath.compareEndingPath("results")) {
          List<Result> results = queryResultPath.getLastObject();
          Result result = new Result();
          results.add(result);
          addedName = "result";
Severity: Major
Found in src/main/java/org/influxdb/msgpack/MessagePackTraverser.java and 7 other locations - About 35 mins to fix
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 183..189
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 177..183
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 171..177
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 165..171
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 159..165
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 214..220
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 208..214

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          } else if ("values".equals(lastStringNode) && queryResultPath.compareEndingPath("series")) {
            Series series = queryResultPath.getLastObject();
            List<List<Object>> values = new ArrayList<>();
            series.setValues(values);
            addedName = "values";
Severity: Major
Found in src/main/java/org/influxdb/msgpack/MessagePackTraverser.java and 7 other locations - About 35 mins to fix
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 183..189
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 171..177
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 165..171
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 159..165
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 214..220
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 208..214
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 202..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        } else if ("tags".equals(lastStringNode) && queryResultPath.compareEndingPath("series")) {
          Series series = queryResultPath.getLastObject();
          Map<String, String> tags = new HashMap<>();
          series.setTags(tags);
          addedName = "tags";
Severity: Major
Found in src/main/java/org/influxdb/msgpack/MessagePackTraverser.java and 7 other locations - About 35 mins to fix
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 183..189
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 177..183
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 171..177
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 165..171
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 159..165
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 208..214
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 202..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    return Objects.equals(measurement, point.measurement)
            && Objects.equals(tags, point.tags)
            && Objects.equals(time, point.time)
            && precision == point.precision
Severity: Minor
Found in src/main/java/org/influxdb/dto/Point.java and 1 other location - About 35 mins to fix
src/main/java/org/influxdb/dto/BatchPoints.java on lines 344..347

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    return Objects.equals(database, that.database)
            && Objects.equals(retentionPolicy, that.retentionPolicy)
            && Objects.equals(tags, that.tags)
            && consistency == that.consistency;
Severity: Minor
Found in src/main/java/org/influxdb/dto/BatchPoints.java and 1 other location - About 35 mins to fix
src/main/java/org/influxdb/dto/Point.java on lines 489..492

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        } else if (queryResultPath.compareEndingPath("seriesList")) {
          List<Series> series = queryResultPath.getLastObject();
          Series s = new Series();
          series.add(s);
          addedName = "series";
Severity: Major
Found in src/main/java/org/influxdb/msgpack/MessagePackTraverser.java and 7 other locations - About 35 mins to fix
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 183..189
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 177..183
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 171..177
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 165..171
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 159..165
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 214..220
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 202..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          } else if ("columns".equals(lastStringNode) && queryResultPath.compareEndingPath("series")) {
            Series series = queryResultPath.getLastObject();
            List<String> columns = new ArrayList<>();
            series.setColumns(columns);
            addedName = "columns";
Severity: Major
Found in src/main/java/org/influxdb/msgpack/MessagePackTraverser.java and 7 other locations - About 35 mins to fix
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 183..189
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 177..183
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 165..171
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 159..165
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 214..220
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 208..214
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 202..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          if ("results".equals(lastStringNode)) {
            QueryResult queryResult = queryResultPath.getLastObject();
            List<Result> results = new ArrayList<>();
            queryResult.setResults(results);
            addedName = "results";
Severity: Major
Found in src/main/java/org/influxdb/msgpack/MessagePackTraverser.java and 7 other locations - About 35 mins to fix
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 183..189
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 177..183
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 171..177
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 165..171
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 214..220
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 208..214
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 202..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          } else if (queryResultPath.compareEndingPath("values")) {
            List<List<Object>> values = queryResultPath.getLastObject();
            List<Object> value = new ArrayList<>();
            values.add(value);
            addedName = "value";
Severity: Major
Found in src/main/java/org/influxdb/msgpack/MessagePackTraverser.java and 7 other locations - About 35 mins to fix
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 177..183
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 171..177
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 165..171
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 159..165
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 214..220
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 208..214
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 202..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          } else if ("series".equals(lastStringNode) && queryResultPath.compareEndingPath("result")) {
            Result result = queryResultPath.getLastObject();
            List<Series> series = new ArrayList<>();
            result.setSeries(series);
            addedName = "seriesList";
Severity: Major
Found in src/main/java/org/influxdb/msgpack/MessagePackTraverser.java and 7 other locations - About 35 mins to fix
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 183..189
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 177..183
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 171..177
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 159..165
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 214..220
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 208..214
src/main/java/org/influxdb/msgpack/MessagePackTraverser.java on lines 202..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

          if (colAnnotation == null && !(allFields
                  && !field.isAnnotationPresent(Exclude.class) && !Modifier.isStatic(field.getModifiers()))) {
            continue;
          }
Severity: Minor
Found in src/main/java/org/influxdb/impl/InfluxDBResultMapper.java and 1 other location - About 30 mins to fix
src/main/java/org/influxdb/dto/Point.java on lines 298..301

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

          if (column == null && !(allFields
                  && !field.isAnnotationPresent(Exclude.class) && !Modifier.isStatic(field.getModifiers()))) {
            continue;
          }
Severity: Minor
Found in src/main/java/org/influxdb/dto/Point.java and 1 other location - About 30 mins to fix
src/main/java/org/influxdb/impl/InfluxDBResultMapper.java on lines 229..232

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

      return new HintedHandOffQueueNotEmptyException(errorMessage);
Severity: Major
Found in src/main/java/org/influxdb/InfluxDBException.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

              return Instant.ofEpochMilli(toMillis(((Integer) value).longValue(), precision));
    Severity: Major
    Found in src/main/java/org/influxdb/impl/InfluxDBResultMapper.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return new AuthorizationFailedException(errorMessage);
      Severity: Major
      Found in src/main/java/org/influxdb/InfluxDBException.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return false;
        Severity: Major
        Found in src/main/java/org/influxdb/dto/Query.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return false;
          Severity: Major
          Found in src/main/java/org/influxdb/dto/Query.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return new CacheMaxMemorySizeExceededException(errorMessage);
            Severity: Major
            Found in src/main/java/org/influxdb/InfluxDBException.java - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language