Sign upLogin

influxdata/influxdb-java

View on GitHub
Star
src/main/java/org/influxdb/dto/Point.java

Summary

Maintainability
F
3 days
Test Coverage

File Point.java has 453 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package org.influxdb.dto;

import org.influxdb.BuilderException;
import org.influxdb.InfluxDBMapperException;
import org.influxdb.annotation.Column;
Severity: Minor
Found in src/main/java/org/influxdb/dto/Point.java - About 6 hrs to fix

    Method addFieldsFromPOJO has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        public Builder addFieldsFromPOJO(final Object pojo) {

      Class<?> clazz = pojo.getClass();
      Measurement measurement = clazz.getAnnotation(Measurement.class);
      boolean allFields = measurement != null && measurement.allFields();
    Severity: Minor
    Found in src/main/java/org/influxdb/dto/Point.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Point has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class Point {
  private String measurement;
  private Map<String, String> tags;
  private Number time;
  private TimeUnit precision = TimeUnit.NANOSECONDS;
    Severity: Minor
    Found in src/main/java/org/influxdb/dto/Point.java - About 2 hrs to fix

      Method setField has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          private void setField(
            final Class<?> fieldType,
            final String columnName,
            final Object value) {
      if (boolean.class.isAssignableFrom(fieldType) || Boolean.class.isAssignableFrom(fieldType)) {
      Severity: Minor
      Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method concatenatedFields has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        private int concatenatedFields(final StringBuilder sb) {
    int fieldCount = 0;
    for (Entry<String, Object> field : this.fields.entrySet()) {
      Object value = field.getValue();
      if (value == null || isNotFinite(value)) {
      Severity: Minor
      Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method addFieldsFromPOJO has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public Builder addFieldsFromPOJO(final Object pojo) {

      Class<?> clazz = pojo.getClass();
      Measurement measurement = clazz.getAnnotation(Measurement.class);
      boolean allFields = measurement != null && measurement.allFields();
      Severity: Minor
      Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

        Method addFieldByAttribute has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private void addFieldByAttribute(final Object pojo, final Field field, final boolean tag,
                                     final String fieldName, final TypeMapper typeMapper) {
      try {
        Object fieldValue = field.get(pojo);
        Severity: Minor
        Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

          Method formatedTime has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            private void formatedTime(final StringBuilder sb, final TimeUnit precision) {
    if (this.time == null) {
      return;
    }
    TimeUnit converterPrecision = precision;
          Severity: Minor
          Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method formatedTime has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            private void formatedTime(final StringBuilder sb, final TimeUnit precision) {
    if (this.time == null) {
      return;
    }
    TimeUnit converterPrecision = precision;
          Severity: Minor
          Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

            Method concatenatedFields has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              private int concatenatedFields(final StringBuilder sb) {
    int fieldCount = 0;
    for (Entry<String, Object> field : this.fields.entrySet()) {
      Object value = field.getValue();
      if (value == null || isNotFinite(value)) {
            Severity: Minor
            Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

              Method addFieldByAttribute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  private void addFieldByAttribute(final Object pojo, final Field field, final boolean tag,
                                     final String fieldName, final TypeMapper typeMapper) {
      try {
        Object fieldValue = field.get(pojo);
              Severity: Minor
              Found in src/main/java/org/influxdb/dto/Point.java - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method equals has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                @Override
  public boolean equals(final Object o) {
    if (this == o) {
      return true;
    }
              Severity: Minor
              Found in src/main/java/org/influxdb/dto/Point.java - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method addFieldByAttribute has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  private void addFieldByAttribute(final Object pojo, final Field field, final boolean tag,
                                     final String fieldName, final TypeMapper typeMapper) {
              Severity: Minor
              Found in src/main/java/org/influxdb/dto/Point.java - About 35 mins to fix

                Method field has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    @SuppressWarnings("checkstyle:finalparameters")
    @Deprecated
    public Builder field(final String field, Object value) {
      if (value instanceof Number) {
        if (value instanceof Byte) {
                Severity: Minor
                Found in src/main/java/org/influxdb/dto/Point.java - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    return Objects.equals(measurement, point.measurement)
            && Objects.equals(tags, point.tags)
            && Objects.equals(time, point.time)
            && precision == point.precision
                Severity: Minor
                Found in src/main/java/org/influxdb/dto/Point.java and 1 other location - About 35 mins to fix
                src/main/java/org/influxdb/dto/BatchPoints.java on lines 344..347

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 44.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                          if (column == null && !(allFields
                  && !field.isAnnotationPresent(Exclude.class) && !Modifier.isStatic(field.getModifiers()))) {
            continue;
          }
                Severity: Minor
                Found in src/main/java/org/influxdb/dto/Point.java and 1 other location - About 30 mins to fix
                src/main/java/org/influxdb/impl/InfluxDBResultMapper.java on lines 229..232

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 42.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status