Sign upLogin

influxdata/influxdb-java

View on GitHub
Star
src/main/java/org/influxdb/querybuilder/Appender.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method appendName has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  public static StringBuilder appendName(final Object name, final StringBuilder stringBuilder) {
    if (name instanceof String) {
      appendName((String) name, stringBuilder);
    } else if (name instanceof Column) {
      appendName(((Column) name).getName(), stringBuilder);
Severity: Minor
Found in src/main/java/org/influxdb/querybuilder/Appender.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method appendValue has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  public static StringBuilder appendValue(final Object value, final StringBuilder stringBuilder) {
    if (value instanceof Appendable) {
      Appendable appendable = (Appendable) value;
      appendable.appendTo(stringBuilder);
    } else if (value instanceof Function) {
Severity: Minor
Found in src/main/java/org/influxdb/querybuilder/Appender.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method appendName has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public static StringBuilder appendName(final Object name, final StringBuilder stringBuilder) {
    if (name instanceof String) {
      appendName((String) name, stringBuilder);
    } else if (name instanceof Column) {
      appendName(((Column) name).getName(), stringBuilder);
Severity: Minor
Found in src/main/java/org/influxdb/querybuilder/Appender.java - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        } else if (name instanceof Function) {
      Function functionCall = (Function) name;
      stringBuilder.append(functionCall.getName()).append('(');
      for (int i = 0; i < functionCall.getParameters().length; i++) {
        if (i > 0) {
    Severity: Major
    Found in src/main/java/org/influxdb/querybuilder/Appender.java and 1 other location - About 1 hr to fix
    src/main/java/org/influxdb/querybuilder/Appender.java on lines 53..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        } else if (value instanceof Function) {
      Function functionCall = (Function) value;
      stringBuilder.append(functionCall.getName()).append('(');
      for (int i = 0; i < functionCall.getParameters().length; i++) {
        if (i > 0) {
    Severity: Major
    Found in src/main/java/org/influxdb/querybuilder/Appender.java and 1 other location - About 1 hr to fix
    src/main/java/org/influxdb/querybuilder/Appender.java on lines 91..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status