Sign upLogin

infusionvlc/ConexionFelina

View on GitHub
Star

Showing 303 of 303 total issues

Line is too long. [85/80]
Open

    params.require(:treatment_entry).permit(:date, :treatment, :notes, :suffering_id)
Severity: Minor
Found in app/controllers/treatment_entries_controller.rb by rubocop

Line is too long. [82/80]
Open

      record.errors[:last_payment_date] << "Last payment date must be in the past"
Severity: Minor
Found in app/validators/sponsor_validator.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

    if record.status.eql?(4) && record.dischargement_date.nil?
Severity: Minor
Found in app/validators/suffering_validator.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Use the new Ruby 1.9 hash syntax.
Open

  validate :birthday_date_must_be_in_the_past, :if => :active_or_basic_info?
Severity: Minor
Found in app/models/cat.rb by rubocop

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

Tab detected.
Open

    belongs_to :colony
Severity: Minor
Found in app/models/colonies_user.rb by rubocop

Inconsistent indentation detected.
Open

    validates :username, :email, :role, :purrs, presence: true
Severity: Minor
Found in app/models/user.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Tab detected.
Open

    has_many :adoptions
Severity: Minor
Found in app/models/user.rb by rubocop

Tab detected.
Open

    has_many :cats, through: :adoptions
Severity: Minor
Found in app/models/user.rb by rubocop

Space inside parentheses detected.
Open

    redirect_to( illnesses_path )
Severity: Minor
Found in app/controllers/illnesses_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Space inside parentheses detected.
Open

    redirect_to( locations_path )
Severity: Minor
Found in app/controllers/locations_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Line is too long. [103/80]
Open

    params.require(:suffering).permit(:diagnosis_date, :notes, :chronic, :status, :cat_id, :illness_id)
Severity: Minor
Found in app/controllers/sufferings_controller.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    !@user.nil? && (@user.role == "volunteer" || @user.role == "admin")
Severity: Minor
Found in app/policies/cat_policy.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [87/80]
Open

  accepts_nested_attributes_for :sufferings, reject_if: :all_blank, allow_destroy: true
Severity: Minor
Found in app/models/cat.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

    if birthday_date != nil
Severity: Minor
Found in app/models/cat.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Space inside { missing.
Open

  validates :amount, numericality: {only_integer: true, greater_than: MINIMUM_AMOUNT_VALUE}
Severity: Minor
Found in app/models/donation.rb by rubocop

Checks that braces used for hash literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that hash literals have
# surrounding space.

# bad
h = {a: 1, b: 2}

# good
h = { a: 1, b: 2 }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that hash literals have
# no surrounding space.

# bad
h = { a: 1, b: 2 }

# good
h = {a: 1, b: 2}

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# hash braces, with the exception that successive left
# braces or right braces are collapsed together in nested hashes.

# bad
h = { a: { b: 2 } }

# good
h = { a: { b: 2 }}

Space inside { missing.
Open

  validates :name, length: {maximum: MAXIMUM_NAME_COLONY_LENGTH}
Severity: Minor
Found in app/models/colony.rb by rubocop

Checks that braces used for hash literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that hash literals have
# surrounding space.

# bad
h = {a: 1, b: 2}

# good
h = { a: 1, b: 2 }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that hash literals have
# no surrounding space.

# bad
h = { a: 1, b: 2 }

# good
h = {a: 1, b: 2}

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# hash braces, with the exception that successive left
# braces or right braces are collapsed together in nested hashes.

# bad
h = { a: { b: 2 } }

# good
h = { a: { b: 2 }}

Inconsistent indentation detected.
Open

    MAXIMUM_BIO_LENGTH = 512
Severity: Minor
Found in app/models/user.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Tab detected.
Open
Severity: Minor
Found in app/models/illness.rb by rubocop

Do not use space inside reference brackets.
Open

    @illness = Illness.find( params[ :id ])
Severity: Minor
Found in app/controllers/illnesses_controller.rb by rubocop

Checks that reference brackets have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: no_space (default)

# The `no_space` style enforces that reference brackets have
# no surrounding space.

# bad
hash[ :key ]
array[ index ]

# good
hash[:key]
array[index]

Example: EnforcedStyle: space

# The `space` style enforces that reference brackets have
# surrounding space.

# bad
hash[:key]
array[index]

# good
hash[ :key ]
array[ index ]

Do not use space inside reference brackets.
Open

    @illness = Illness.find( params[ :id ])
Severity: Minor
Found in app/controllers/illnesses_controller.rb by rubocop

Checks that reference brackets have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: no_space (default)

# The `no_space` style enforces that reference brackets have
# no surrounding space.

# bad
hash[ :key ]
array[ index ]

# good
hash[:key]
array[index]

Example: EnforcedStyle: space

# The `space` style enforces that reference brackets have
# surrounding space.

# bad
hash[:key]
array[index]

# good
hash[ :key ]
array[ index ]
Severity
Category
Status
Source
Language