Sign upLogin

ingadhoc/odoo-argentina

View on GitHub
Star
l10n_ar_account_followup/account_followup.py

Summary

Maintainability
D
2 days
Test Coverage

Function get_followup_table_html has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def get_followup_table_html(self, cr, uid, ids, context=None):
        """ Build the html tables to be included in emails send to partners,
            when reminding them their overdue invoices.
            :param ids: [id] of the partner for whom we are building the tables
            :rtype: string
Severity: Minor
Found in l10n_ar_account_followup/account_followup.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _get_amounts_and_date has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def _get_amounts_and_date(self, cr, uid, ids, name, arg, context=None):
            
        res = {}
        company = self.pool.get('res.users').browse(cr, uid, uid, context=context).company_id
        company_obj=self.pool.get('res.company')
Severity: Minor
Found in l10n_ar_account_followup/account_followup.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _get_amounts_and_date has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _get_amounts_and_date(self, cr, uid, ids, name, arg, context=None):
Severity: Minor
Found in l10n_ar_account_followup/account_followup.py - About 45 mins to fix

    Function _payment_overdue_search has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _payment_overdue_search(self, cr, uid, obj, name, args, context=None):
    Severity: Minor
    Found in l10n_ar_account_followup/account_followup.py - About 45 mins to fix

      Function _payment_due_search has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def _payment_due_search(self, cr, uid, obj, name, args, context=None):
      Severity: Minor
      Found in l10n_ar_account_followup/account_followup.py - About 45 mins to fix

        Function _payment_earliest_date_search has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def _payment_earliest_date_search(self, cr, uid, obj, name, args, context=None):
        Severity: Minor
        Found in l10n_ar_account_followup/account_followup.py - About 45 mins to fix

          Function do_button_print has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def do_button_print(self, cr, uid, ids, company_id=False, context=None):
          Severity: Minor
          Found in l10n_ar_account_followup/account_followup.py - About 35 mins to fix

            Function _get_followup_overdue_query has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def _get_followup_overdue_query(self, cr, uid, args, overdue_only=False, context=None):
            Severity: Minor
            Found in l10n_ar_account_followup/account_followup.py - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def _payment_overdue_search(self, cr, uid, obj, name, args, context=None):
        if not args:
            return []
        query, query_args = self._get_followup_overdue_query(cr, uid, args, overdue_only=True, context=context)
        cr.execute(query, query_args)
              Severity: Major
              Found in l10n_ar_account_followup/account_followup.py and 1 other location - About 6 hrs to fix
              l10n_ar_account_followup/account_followup.py on lines 77..85

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 107.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def _payment_due_search(self, cr, uid, obj, name, args, context=None):
        if not args:
            return []
        query, query_args = self._get_followup_overdue_query(cr, uid, args, overdue_only=False, context=context)
        cr.execute(query, query_args)
              Severity: Major
              Found in l10n_ar_account_followup/account_followup.py and 1 other location - About 6 hrs to fix
              l10n_ar_account_followup/account_followup.py on lines 87..95

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 107.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      having_where_clause = ' AND '.join(map(lambda x: '(SUM(bal2) %s %%s)' % (x[1]), args))
              Severity: Minor
              Found in l10n_ar_account_followup/account_followup.py and 1 other location - About 40 mins to fix
              l10n_ar_account_followup/account_followup.py on lines 59..59

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      having_where_clause = ' AND '.join(map(lambda x: '(MIN(l.date_maturity) %s %%s)' % (x[1]), args))
              Severity: Minor
              Found in l10n_ar_account_followup/account_followup.py and 1 other location - About 40 mins to fix
              l10n_ar_account_followup/account_followup.py on lines 32..32

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status