Sign upLogin

initiatived21/d21

View on GitHub
Star
app/controllers/pledges_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Class has too many lines. [203/100]
Open

class PledgesController < ApplicationController
  before_action :set_new_form, only: [:new, :create]
  before_action :set_edit_form, only: [:edit, :update, :finalize]
  before_action :authenticate_user!, except: [:new, :create, :index, :show]
Severity: Minor
Found in app/controllers/pledges_controller.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [32/10]
Open

  def show
    @pledge = Pledge.includes(:initiator).find(params[:id])

    authorize @pledge
Severity: Minor
Found in app/controllers/pledges_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for show is too high. [31.06/15]
Open

  def show
    @pledge = Pledge.includes(:initiator).find(params[:id])

    authorize @pledge
Severity: Minor
Found in app/controllers/pledges_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [19/10]
Open

  def create_success!
    @form.save
    sign_in @form.model.initiator unless current_user
    respond_to do |format|
      format.json do
Severity: Minor
Found in app/controllers/pledges_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [18/10]
Open

  def index
    search = Search.new(params)

    search.run
    @pledges = search.solved_results
Severity: Minor
Found in app/controllers/pledges_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for create_success! is too high. [18.14/15]
Open

  def create_success!
    @form.save
    sign_in @form.model.initiator unless current_user
    respond_to do |format|
      format.json do
Severity: Minor
Found in app/controllers/pledges_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [12/10]
Open

  def update_success!
    @form.save
    respond_to do |format|
      format.json do
        render json: {
Severity: Minor
Found in app/controllers/pledges_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [12/10]
Open

  def pledge_form_props method, path
    {
      form: {
        action: path,
        authToken: form_authenticity_token,
Severity: Minor
Found in app/controllers/pledges_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for index is too high. [16.67/15]
Open

  def index
    search = Search.new(params)

    search.run
    @pledges = search.solved_results
Severity: Minor
Found in app/controllers/pledges_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [11/10]
Open

  def create_failed!
    respond_to do |format|
      format.json do
        render(
          json: {
Severity: Minor
Found in app/controllers/pledges_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for destroy is too high. [16.28/15]
Open

  def destroy
    @pledge = Pledge.where(id: params[:id]).includes(:signatures).first
    signatures = @pledge.signatures.confirmed.all.to_a
    authorize @pledge
    @pledge.destroy!
Severity: Minor
Found in app/controllers/pledges_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method show has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def show
    @pledge = Pledge.includes(:initiator).find(params[:id])

    authorize @pledge
Severity: Minor
Found in app/controllers/pledges_controller.rb - About 1 hr to fix

    Missing magic comment # frozen_string_literal: true.
    Open

    class PledgesController < ApplicationController
    Severity: Minor
    Found in app/controllers/pledges_controller.rb by rubocop

    This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

    Example: EnforcedStyle: when_needed (default)

    # The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

    Example: EnforcedStyle: always

    # The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

    Example: EnforcedStyle: never

    # The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

    Use %i or %I for an array of symbols.
    Open

      before_action :set_new_form, only: [:new, :create]
    Severity: Minor
    Found in app/controllers/pledges_controller.rb by rubocop

    This cop can check for array literals made up of symbols that are not using the %i() syntax.

    Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

    Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

    Example: EnforcedStyle: percent (default)

    # good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

    Example: EnforcedStyle: brackets

    # good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

    Use %i or %I for an array of symbols.
    Open

      before_action :authenticate_user!, except: [:new, :create, :index, :show]
    Severity: Minor
    Found in app/controllers/pledges_controller.rb by rubocop

    This cop can check for array literals made up of symbols that are not using the %i() syntax.

    Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

    Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

    Example: EnforcedStyle: percent (default)

    # good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

    Example: EnforcedStyle: brackets

    # good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

    Use %i or %I for an array of symbols.
    Open

      before_action :set_edit_form, only: [:edit, :update, :finalize]
    Severity: Minor
    Found in app/controllers/pledges_controller.rb by rubocop

    This cop can check for array literals made up of symbols that are not using the %i() syntax.

    Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

    Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

    Example: EnforcedStyle: percent (default)

    # good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

    Example: EnforcedStyle: brackets

    # good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

    There are no issues that match your filters.

    Category
    Status