Sign upLogin

inklabs/kommerce-core

View on GitHub
Star
src/Service/OrderService.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        EventDispatcherInterface $eventDispatcher,
        InventoryServiceInterface $inventoryService,
        OrderRepositoryInterface $orderRepository,
        OrderItemRepositoryInterface $orderItemRepository,
        PaymentGatewayInterface $paymentGateway,
Severity: Major
Found in src/Service/OrderService.php - About 1 hr to fix

    Method createOrderFromCart has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            UuidInterface $orderId,
        User $user,
        Cart $cart,
        CartCalculatorInterface $cartCalculator,
        string $ip4,
    Severity: Major
    Found in src/Service/OrderService.php - About 1 hr to fix

      Method addShipmentTrackingCode has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              UuidInterface $orderId,
        OrderItemQtyDTO $orderItemQtyDTO,
        string $comment,
        int $shipmentCarrierTypeId,
        string $trackingCode
      Severity: Minor
      Found in src/Service/OrderService.php - About 35 mins to fix

        Method buyShipmentLabel has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                UuidInterface $orderId,
        OrderItemQtyDTO $orderItemQtyDTO,
        string $comment,
        string $rateExternalId,
        string $shipmentExternalId
        Severity: Minor
        Found in src/Service/OrderService.php - About 35 mins to fix

          Function shipProductsFromInventory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function shipProductsFromInventory(Order $order, OrderItemQtyDTO $orderItemQtyDTO): void
    {
        foreach ($order->getOrderItems() as $orderItem) {
            $quantity = $orderItemQtyDTO->getItemQuantity($orderItem->getId());
            if ($quantity !== null) {
          Severity: Minor
          Found in src/Service/OrderService.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status