Sign upLogin

inklabs/rangedb

View on GitHub
Star
provider/inmemorystore/inmemory_store.go

Summary

Maintainability
A
3 hrs
Test Coverage
A
97%

Showing 4 of 4 total issues

Method inMemoryStore.saveEvents has 59 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (s *inMemoryStore) saveEvents(ctx context.Context, expectedStreamSequenceNumber *uint64, streamName string, eventRecords ...*rangedb.EventRecord) (uint64, error) {
    if len(eventRecords) < 1 {
        return 0, fmt.Errorf("missing events")
    }
 
 
Severity: Minor
Found in provider/inmemorystore/inmemory_store.go - About 1 hr to fix

    Method inMemoryStore.saveEvents has 6 return statements (exceeds 4 allowed).
    Open

    func (s *inMemoryStore) saveEvents(ctx context.Context, expectedStreamSequenceNumber *uint64, streamName string, eventRecords ...*rangedb.EventRecord) (uint64, error) {
        if len(eventRecords) < 1 {
            return 0, fmt.Errorf("missing events")
        }
     
     
    Severity: Major
    Found in provider/inmemorystore/inmemory_store.go - About 40 mins to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      func (s *inMemoryStore) AggregateTypesSubscription(ctx context.Context, bufferSize int, subscriber rangedb.RecordSubscriber, aggregateTypes ...string) rangedb.RecordSubscription {
          return recordsubscriber.New(
              recordsubscriber.AggregateTypesConfig(ctx, s, s.broadcaster, bufferSize,
                  aggregateTypes,
                  func(record *rangedb.Record) error {
      Severity: Major
      Found in provider/inmemorystore/inmemory_store.go and 4 other locations - About 1 hr to fix
      provider/eventstore/eventstore.go on lines 584..593
      provider/leveldbstore/leveldb_store.go on lines 344..353
      provider/postgresstore/postgres_store.go on lines 350..359
      provider/remotestore/remote_store.go on lines 277..286

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      func (s *inMemoryStore) AllEventsSubscription(ctx context.Context, bufferSize int, subscriber rangedb.RecordSubscriber) rangedb.RecordSubscription {
          return recordsubscriber.New(
              recordsubscriber.AllEventsConfig(ctx, s, s.broadcaster, bufferSize,
                  func(record *rangedb.Record) error {
                      subscriber.Accept(record)
      Severity: Major
      Found in provider/inmemorystore/inmemory_store.go and 4 other locations - About 50 mins to fix
      provider/eventstore/eventstore.go on lines 574..582
      provider/leveldbstore/leveldb_store.go on lines 334..342
      provider/postgresstore/postgres_store.go on lines 340..348
      provider/remotestore/remote_store.go on lines 267..275
      Category
      Status