Sign upLogin

innoq/iqvoc

View on GitHub
Star
app/aides/skos_importer.rb

Summary

Maintainability
D
1 day
Test Coverage

Method import_second_level_objects has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def import_second_level_objects(types, final, line)
    subject, predicate, object = *extract_triple(line)

    return unless (subject =~ /^:(.*)$/ && types[predicate]) # We're not responsible for this
Severity: Minor
Found in app/aides/skos_importer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File skos_importer.rb has 265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class SkosImporter
  class_attribute :first_level_object_classes, :second_level_object_classes
  self.first_level_object_classes = [
    Iqvoc::Concept.base_class,
    Iqvoc::Collection.base_class
Severity: Minor
Found in app/aides/skos_importer.rb - About 2 hrs to fix

    Method import has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def import(file)
    ActiveSupport.run_load_hooks(:skos_importer_before_import, self)

    start = Time.now
    Severity: Minor
    Found in app/aides/skos_importer.rb - About 1 hr to fix

      Method import_first_level_objects has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def import_first_level_objects(types, subject, predicate, object)
    if (predicate == 'rdf:type' && types[object] && subject =~ /^:(.+)$/)
      # We've found a subject definition with a class we know and which is in our responsibility (":")
      origin = $1
      Severity: Minor
      Found in app/aides/skos_importer.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import_second_level_objects has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def import_second_level_objects(types, final, line)
    subject, predicate, object = *extract_triple(line)

    return unless (subject =~ /^:(.*)$/ && types[predicate]) # We're not responsible for this
      Severity: Minor
      Found in app/aides/skos_importer.rb - About 1 hr to fix

        Method initialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(object, default_namespace_url, logger = Rails.logger, publish = true, verbose = false)
    @file = case object
              when File
                File.open(object)
              when Array
        Severity: Minor
        Found in app/aides/skos_importer.rb - About 1 hr to fix

          Method import has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def import(file)
    ActiveSupport.run_load_hooks(:skos_importer_before_import, self)

    start = Time.now
          Severity: Minor
          Found in app/aides/skos_importer.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def initialize(object, default_namespace_url, logger = Rails.logger, publish = true, verbose = false)
          Severity: Minor
          Found in app/aides/skos_importer.rb - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              self.second_level_object_classes = Iqvoc::Concept.labeling_classes.keys +
    Iqvoc::Concept.note_classes +
    Iqvoc::Concept.relation_classes +
    Iqvoc::Concept.match_classes +
    Iqvoc::Concept.notation_classes +
            Severity: Minor
            Found in app/aides/skos_importer.rb and 1 other location - About 25 mins to fix
            app/aides/rdfapi.rb on lines 19..25

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 30.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                unless subject
      if final
        @logger.warn "SkosImporter: Couldn't find Subject with origin '#{subject_origin}. Skipping entry '#{subject} #{predicate} #{object}.'"
      else
        @unknown_second_level_triples << line
            Severity: Minor
            Found in app/aides/skos_importer.rb and 1 other location - About 15 mins to fix
            app/aides/skos_importer.rb on lines 225..231

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  unless object
        if final
          @logger.warn "SkosImporter: Couldn't find Object with origin '#{object_origin}'. Skipping entry ':#{subject_origin} #{predicate} #{object_origin}.'"
        else
          @unknown_second_level_triples << line
            Severity: Minor
            Found in app/aides/skos_importer.rb and 1 other location - About 15 mins to fix
            app/aides/skos_importer.rb on lines 212..218

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status