Sign upLogin

inossidabile/heimdallr

View on GitHub
Star

Showing 17 of 17 total issues

Method method_missing has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    def method_missing(method, *args, &block)
      suffix = method.to_s[-1]
      if %w(? = !).include? suffix
        normalized_method = method[0..-2].to_sym
      else
Severity: Minor
Found in lib/heimdallr/proxy/record.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Record has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Proxy::Record
    # Create a record proxy.
    #
    # @param context  security context
    # @param object   proxified record
Severity: Minor
Found in lib/heimdallr/proxy/record.rb - About 2 hrs to fix

    Method includes has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        def includes(*associations)
      # Normalize association list to strict nested hash.
      normalize = ->(list) {
        if list.is_a? Array
          list.map(&normalize).reduce(:merge)
    Severity: Minor
    Found in lib/heimdallr/proxy/collection.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method method_missing has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def method_missing(method, *args, &block)
      suffix = method.to_s[-1]
      if %w(? = !).include? suffix
        normalized_method = method[0..-2].to_sym
      else
    Severity: Major
    Found in lib/heimdallr/proxy/record.rb - About 2 hrs to fix

      Method with_objects_from_params has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def with_objects_from_params(options={})
      model.transaction do
        if @multiple_resources
          begin
            name = model.name.underscore.pluralize
      Severity: Minor
      Found in lib/heimdallr/legacy_resource.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method includes has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def includes(*associations)
      # Normalize association list to strict nested hash.
      normalize = ->(list) {
        if list.is_a? Array
          list.map(&normalize).reduce(:merge)
      Severity: Minor
      Found in lib/heimdallr/proxy/collection.rb - About 1 hr to fix

        Method create_validators has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def create_validators(fields)
      validators = []

      fields.each do |attribute, validations|
        next unless validations.is_a? Hash
        Severity: Minor
        Found in lib/heimdallr/evaluator.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check_attributes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def check_attributes
      @record.errors.clear

      if @record.new_record?
        action = :create
        Severity: Minor
        Found in lib/heimdallr/proxy/record.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check_attributes has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def check_attributes
      @record.errors.clear

      if @record.new_record?
        action = :create
        Severity: Minor
        Found in lib/heimdallr/proxy/record.rb - About 1 hr to fix

          Method render_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def render_data(options={})
      if @multiple_resources
        if options[:verify] && @resources.any?(&:invalid?)
          render :json => { errors: @resources.map(&:errors) }, :status => :unprocessable_entity
        else
          Severity: Minor
          Found in lib/heimdallr/legacy_resource.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                      if result.respond_to? :restrict
              result.restrict(@context, @options)
            else
              result
            end
          Severity: Major
          Found in lib/heimdallr/proxy/record.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                      elsif @options[:implicit]
            nil
          else
            raise Heimdallr::PermissionError, "Attempt to fetch non-whitelisted attribute #{method}"
            Severity: Major
            Found in lib/heimdallr/proxy/record.rb - About 45 mins to fix

              Method request_scope has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def request_scope(name=:fetch, basic_scope=nil)
      unless @scopes.has_key?(name)
        raise RuntimeError, "The #{name.inspect} scope does not exist"
      end
              Severity: Minor
              Found in lib/heimdallr/evaluator.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method check_save_options has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def check_save_options(options)
      if options[:validate] == false
        raise Heimdallr::InsecureOperationError,
            "Saving while omitting validation would omit security validations too"
      end
              Severity: Minor
              Found in lib/heimdallr/proxy/record.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method method_missing has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def method_missing(method, *args)
      if method =~ /^find_all_by/
        @scope.send(method, *args).map do |element|
          element.restrict(@context, options_with_escape)
        end
              Severity: Minor
              Found in lib/heimdallr/proxy/collection.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def self.delegate_as_scope(name, conversion=false)
      conversion = conversion ? "set = set.send(:#{conversion})" : ''

      class_eval(<<-EOM, __FILE__, __LINE__)
      def #{name}(*args)
              Severity: Minor
              Found in lib/heimdallr/proxy/collection.rb and 1 other location - About 15 mins to fix
              lib/heimdallr/proxy/collection.rb on lines 90..101

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def self.delegate_as_records(name, conversion=false)
      conversion = conversion ? "set = set.send(:#{conversion})" : ''

      class_eval(<<-EOM, __FILE__, __LINE__)
      def #{name}(*args)
              Severity: Minor
              Found in lib/heimdallr/proxy/collection.rb and 1 other location - About 15 mins to fix
              lib/heimdallr/proxy/collection.rb on lines 54..62

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language