Sign upLogin

inossidabile/wash_out

View on GitHub
Star
lib/wash_out/router.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method parse_soap_action has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def parse_soap_action(env)
      return env['wash_out.soap_action'] if env['wash_out.soap_action']

      soap_action = controller.soap_config.soap_action_routing ? env['HTTP_SOAPACTION'].to_s.gsub(/^"(.*)"$/, '\1')
                                                               : ''
Severity: Minor
Found in lib/wash_out/router.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method lookup_soap_routes has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def self.lookup_soap_routes(controller_name, routes, path=[], &block)
      routes.each do |x|
        defaults = x.defaults
        defaults = defaults[:defaults] if defaults.include?(:defaults) # Rails 5
        if defaults[:controller] == controller_name && defaults[:action] == 'soap'
Severity: Minor
Found in lib/wash_out/router.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method url has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def self.url(request, controller_name)
      lookup_soap_routes(controller_name, Rails.application.routes.routes) do |routes|

        path = if routes.first.respond_to?(:optimized_path)      # Rails 4
          routes.map(&:optimized_path)
Severity: Minor
Found in lib/wash_out/router.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status