Sign upLogin

integreat-io/integreat

View on GitHub
Star

Showing 64 of 71 total issues

Function handleArray has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const handleArray = (
  fn: CastItemFn,
  isArrayExpected: boolean,
  type?: string,
): CastItemFn =>
Severity: Minor
Found in src/schema/createCast.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function castDate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export default function castDate(value: unknown): Date | null | undefined {
  if (value === null || value === undefined) {
    return value
  } else if (
    isDate(value) ||
Severity: Minor
Found in src/schema/castFns/date.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prepareData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const prepareData = ({ type, id, data }: Payload) =>
  type && id
    ? { id, $type: type } // Delete one action -- return as data
    : Array.isArray(data)
    ? data.filter(isTypedData) // Filter away anything that is not cast data items
Severity: Minor
Found in src/handlers/delete.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function castNumber has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export default function castNumber(value: unknown): number | null | undefined {
  if (typeof value === 'number') {
    return numberOrUndefined(value)
  } else if (value === null || value === undefined) {
    return value
Severity: Minor
Found in src/schema/castFns/number.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const isReference = (value: unknown): value is Reference =>
  isObject(value) && value.hasOwnProperty('$ref')
Severity: Minor
Found in src/utils/is.ts and 1 other location - About 35 mins to fix
src/utils/is.ts on lines 23..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const isTypedData = (value: unknown): value is TypedData =>
  isObject(value) && value.hasOwnProperty('$type')
Severity: Minor
Found in src/utils/is.ts and 1 other location - About 35 mins to fix
src/utils/is.ts on lines 26..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return numberOrUndefined(value.getTime())
Severity: Major
Found in src/schema/castFns/number.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return { status: 'ok' }
    Severity: Major
    Found in src/handlers/sync.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return numberOrUndefined(value.getTime())
      Severity: Major
      Found in src/schema/castFns/integer.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return null
        Severity: Major
        Found in src/schema/castFns/nonPrimitive.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return createErrorResponse(
      response?.error,
      'handler:SYNC',
      response?.status || 'error',
    )
          Severity: Major
          Found in src/handlers/sync.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return authorizeByRoleOrIdent(access, ident)
            Severity: Major
            Found in src/service/utils/authAction.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return undefined
              Severity: Major
              Found in src/schema/castFns/number.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return undefined
                Severity: Major
                Found in src/schema/castFns/nonPrimitive.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return undefined
                  Severity: Major
                  Found in src/schema/castFns/integer.ts - About 30 mins to fix

                    Function ensureAccessObject has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function ensureAccessObject(access?: string | AccessDef | null) {
  if (typeof access === 'string') {
    return massageAccessObject({ allow: access })
  }
  if (typeof access === 'object' && access !== null) {
                    Severity: Minor
                    Found in src/schema/accessForAction.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function castString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export default function castString(value: unknown) {
  if (value === null || value === undefined) {
    return value
  } else if (typeof value === 'object') {
    return isDate(value) ? value.toISOString() : undefined
                    Severity: Minor
                    Found in src/schema/castFns/string.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function setMetaFromParams has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    const setMetaFromParams = (
  dispatch: HandlerDispatch,
  { payload: { type, metaKey }, meta: { id, ...meta } = {} }: Action,
  datesFromData: (Date | undefined)[],
  gottenDataDate: Date,
                    Severity: Minor
                    Found in src/handlers/sync.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function createConditionsValidator has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function createConditionsValidator(
  conditions: TransformDefinition[] | undefined,
  mapOptions: MapOptions,
): (action: Action) => Promise<boolean> {
  if (!conditions) {
                    Severity: Minor
                    Found in src/service/utils/matchEnpoints.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function validateFilters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export default function validateFilters(
  filters: Record<string, Condition | boolean | undefined>,
  useFriendlyMessages = false,
) {
  const filterFns = Object.entries(filters)
                    Severity: Minor
                    Found in src/utils/validateFilters.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language