intellij-lsp/intellij-lsp-plugin

View on GitHub

Showing 774 of 774 total issues

Function requestAndShowDoc has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private def requestAndShowDoc(curTime: Long, editorPos: LogicalPosition, point: Point): Unit = {
    val serverPos = computableReadAction[Position](() => DocumentUtils.logicalToLSPPos(editorPos, editor))
    val request = requestManager.hover(new TextDocumentPositionParams(identifier, serverPos))
    if (request != null) {
      try {

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        EditorEventManager.forEditor(editor) match {
          case Some(manager) =>
            val renameTo = Messages.showInputDialog(e.getProject, "Enter new name: ", "Rename", Messages.getQuestionIcon, "", new NonEmptyInputValidator())
            if (renameTo != null && renameTo != "") manager.rename(renameTo)
          case None =>
    src/main/scala/com/github/gtache/lsp/contributors/rename/LSPRenameHandler.scala on lines 81..86

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          try {
            val res = future.get(CODEACTION_TIMEOUT, TimeUnit.MILLISECONDS).asScala
            wrapper.notifySuccess(Timeouts.CODEACTION)
            res
          } catch {
    src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 725..745
    src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1167..1184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          try {
            val references = future.get(REFERENCES_TIMEOUT, TimeUnit.MILLISECONDS)
            wrapper.notifySuccess(Timeouts.REFERENCES)
            if (references != null) {
              references.asScala.collect {
    src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 354..367
    src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1167..1184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          try {
            val definition = request.get(DEFINITION_TIMEOUT, TimeUnit.MILLISECONDS)
            wrapper.notifySuccess(Timeouts.DEFINITION)
            if (definition != null && !definition.isEmpty()) {
              definition.get(0)
    src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 354..367
    src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 725..745

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function executeCommands has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def executeCommands(commands: Iterable[Command]): Unit = {
        pool(() => {
          if (!editor.isDisposed) {
            commands.map(c => {
              val params = new ExecuteCommandParams()

      Function getElementAtOffset has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def getElementAtOffset(offset: Int): LSPPsiElement = {
          computableReadAction(() => {
            if (!editor.isDisposed) {
              val params = new TextDocumentPositionParams(identifier, DocumentUtils.offsetToLSPPos(editor, offset))
              val future = requestManager.documentHighlight(params)

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                    try {
                      val ret = f.get(EXECUTE_COMMAND_TIMEOUT, TimeUnit.MILLISECONDS)
                      wrapper.notifySuccess(Timeouts.EXECUTE_COMMAND)
                      ret match {
                        case e: WorkspaceEdit => WorkspaceEditHandler.applyEdit(e, name = "Execute command")
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 210..237
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 258..269
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 680..696
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 854..869
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1087..1112
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1382..1405

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

              try {
                val hover = request.get(HOVER_TIMEOUT, TimeUnit.MILLISECONDS)
                wrapper.notifySuccess(Timeouts.HOVER)
                if (hover != null) {
                  val string = HoverHandler.getHoverString(hover)
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 210..237
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 258..269
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 502..516
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 680..696
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 854..869
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1382..1405

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                  try {
                    val signature = future.get(SIGNATURE_TIMEOUT, TimeUnit.MILLISECONDS)
                    wrapper.notifySuccess(Timeouts.SIGNATURE)
                    if (signature != null) {
                      val signatures = signature.getSignatures
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 258..269
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 502..516
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 680..696
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 854..869
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1087..1112
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1382..1405

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                  try {
                    val edits = future.get(FORMATTING_TIMEOUT, TimeUnit.MILLISECONDS)
                    wrapper.notifySuccess(Timeouts.FORMATTING)
                    if (edits != null) invokeLater(() => applyEdit(edits = edits.asScala, name = "On type formatting"))
                  } catch {
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 210..237
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 502..516
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 680..696
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 854..869
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1087..1112
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1382..1405

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                        try {
                          val resp = request.get(DOC_HIGHLIGHT_TIMEOUT, TimeUnit.MILLISECONDS)
                          wrapper.notifySuccess(Timeouts.DOC_HIGHLIGHT)
                          if (resp != null) {
                            invokeLater(() => resp.asScala.foreach(dh => {
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 210..237
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 258..269
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 502..516
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 680..696
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 854..869
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1087..1112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                    try {
                      val edits = future.get(WILLSAVE_TIMEOUT, TimeUnit.MILLISECONDS)
                      wrapper.notifySuccess(Timeouts.WILLSAVE)
                      if (edits != null) {
                        invokeLater(() => applyEdit(edits = edits.asScala, name = "WaitUntil edits"))
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 210..237
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 258..269
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 502..516
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 854..869
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1087..1112
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1382..1405

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                  try {
                    val references = future.get(REFERENCES_TIMEOUT, TimeUnit.MILLISECONDS)
                    wrapper.notifySuccess(Timeouts.REFERENCES)
                    if (references != null) {
                      invokeLater(() => {
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 210..237
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 258..269
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 502..516
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 680..696
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1087..1112
        src/main/scala/com/github/gtache/lsp/editor/EditorEventManager.scala on lines 1382..1405

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function selectionChanged has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def selectionChanged(e: SelectionEvent): Unit = {
            if (CodeInsightSettings.getInstance().HIGHLIGHT_IDENTIFIER_UNDER_CARET) {
              if (e.getEditor == editor) {
                selectedSymbHighlights.foreach(h => editor.getMarkupModel.removeHighlighter(h))
                selectedSymbHighlights.clear()

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method createComboBox has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private JComboBox<String> createComboBox(final JPanel panel, final String selected) {
                final JComboBox<String> typeBox = new ComboBox<>();
                final ConfigurableTypes[] types = ConfigurableTypes.values();
                for (final ConfigurableTypes type : types) {
                    typeBox.addItem(type.getTyp());
        Severity: Minor
        Found in src/main/scala/com/github/gtache/lsp/settings/gui/ServersGUI.java - About 1 hr to fix

          Function scheduleDocumentation has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            private def scheduleDocumentation(time: Long, editorPos: LogicalPosition, point: Point): Unit = {
              if (editorPos != null) {
                if (time - predTime > SCHEDULE_THRES) {
                  try {
                    hoverThread.schedule(new TimerTask {

            Function getHoverString has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def getHoverString(@NonNull hover: Hover): String = {
                import scala.collection.JavaConverters._
                if (hover != null && hover.getContents != null) {
                  val hoverContents = hover.getContents
                  if (hoverContents.isLeft) {
            Severity: Minor
            Found in src/main/scala/com/github/gtache/lsp/requests/HoverHandler.scala - About 1 hr to fix

              Function getEditsRunnable has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def getEditsRunnable(version: Int = Int.MaxValue, edits: Iterable[TextEdit], name: String = "Apply LSP edits"): Runnable = {
                  if (version >= this.version) {
                    val document = editor.getDocument
                    if (document.isWritable) {
                      () => {

                Function mouseClicked has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def mouseClicked(e: EditorMouseEvent): Unit = {
                    if (isCtrlDown) {
                      if (ctrlRange == null)
                        createCtrlRange(DocumentUtils.logicalToLSPPos(editor.xyToLogicalPosition(e.getMouseEvent.getPoint), editor), null)
                      if (ctrlRange != null) {
                  Severity
                  Category
                  Status
                  Source
                  Language