Sign upLogin

interactive-apps/ngx-dhis2-validation-rule-filter

View on GitHub
Star

Showing 1,277 of 1,277 total issues

Function render has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render(isNormalMode) {
        let tp = lithtml.html(`
        <nav>
            <ul class="list">
                <li class="title">
Severity: Major
Found in documentation/js/menu-wc.js - About 3 hrs to fix

    Function displayResults has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function displayResults(res) {
        var noResults = res.count == 0;
        var groups = {};
        $searchResults.toggleClass('no-results', noResults);
    Severity: Major
    Found in documentation/js/search/search.js - About 2 hrs to fix

      File ngx-dhis2-validation-rule-filter.component.ts has 264 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import { Component, OnInit, EventEmitter, Output, Input } from '@angular/core';
import * as _ from 'lodash';
import { Store } from '@ngrx/store';
import { Observable } from 'rxjs';
import { State } from '../../store/reducers/validation-rule-groups.reducers';
      Severity: Minor
      Found in projects/ngx-dhis2-validation-rule-filter/src/lib/containers/validation-rule-group/ngx-dhis2-validation-rule-filter.component.ts - About 2 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    switch (COMPODOC_CURRENT_PAGE_DEPTH) {
                case 5:
                    prefix = '../../../../../';
                    break;
                case 4:
        Severity: Major
        Found in documentation/js/menu.js and 1 other location - About 2 hrs to fix
        documentation/js/menu.js on lines 89..108

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            switch (COMPODOC_CURRENT_PAGE_DEPTH) {
                        case 5:
                            prefix = '../../../../../';
                            break;
                        case 4:
        Severity: Major
        Found in documentation/js/menu.js and 1 other location - About 2 hrs to fix
        documentation/js/menu.js on lines 33..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (COMPONENTS[i].selector === value.name) {
                    newNode.font = {
                        multi: 'html'
                    };
                    newNode.label = '<b>' + newNode.label + '</b>';
        Severity: Major
        Found in documentation/js/tree.js and 1 other location - About 1 hr to fix
        documentation/js/tree.js on lines 79..86

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                if (DIRECTIVES[i].selector.indexOf(attr) !== -1) {
                            newNode.font = {
                                multi: 'html'
                            };
                            newNode.label = '<b>' + newNode.label + '</b>';
        Severity: Major
        Found in documentation/js/tree.js and 1 other location - About 1 hr to fix
        documentation/js/tree.js on lines 67..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function bindSearch has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function bindSearch() {
        // Bind DOM
        $searchInputs        = $('#book-search-input input');

        $searchResults = $('.search-results');
        Severity: Minor
        Found in documentation/js/search/search.js - About 1 hr to fix

          Function getAllValidationRuleGroup has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function getAllValidationRuleGroup(apiResult: APIResult) {
    if (apiResult.hasOwnProperty('validationRules')) {
        const validationRules = apiResult.validationRules || [];
        if (validationRules.length !== 0) {
            const validationRuleGroup = validationRules.map(
          Severity: Minor
          Found in projects/ngx-dhis2-validation-rule-filter/src/lib/helpers/extract-validation-rule-group.helper.ts - About 1 hr to fix

            Function ngOnInit has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              ngOnInit() {
    this.currentPageAvailable = 1;
    this.store.select(getAllValidationRuleGroups);
    this.store.dispatch(new LoadValidationRuleGroups(this.dataSelection));
    this.store
            Severity: Minor
            Found in projects/ngx-dhis2-validation-rule-filter/src/lib/containers/validation-rule-group/ngx-dhis2-validation-rule-filter.component.ts - About 1 hr to fix

              Function reducer has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export function reducer(state = initialState, action: VRGActionTypes): State {
    switch (action.type) {
        case ValidationRuleGroupActions.LOAD_VALIDATION_RULE_GROUPS: {
            return {
                ...state,
              Severity: Minor
              Found in projects/ngx-dhis2-validation-rule-filter/src/lib/store/reducers/validation-rule-groups.reducers.ts - About 1 hr to fix

                Function processLogos has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    var processLogos = function(entityLogo) {
        for (var i = 0; i < entityLogos.length; i++) {
            var entityLogo = entityLogos[i];
            if (entityLogo) {
                var url = entityLogo.getAttribute('data-src');
                Severity: Minor
                Found in documentation/js/menu.js - About 1 hr to fix

                  Function toggleItemMenu has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                              toggleItemMenu = function(e) {
                var element = $(e.target),
                    parent = element[0].parentNode,
                    parentLink,
                    elementIconChild;
                  Severity: Minor
                  Found in documentation/js/menu.js - About 1 hr to fix

                    Function getAllValidationRuleGroup has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function getAllValidationRuleGroup(apiResult: APIResult) {
    if (apiResult.hasOwnProperty('validationRules')) {
        const validationRules = apiResult.validationRules || [];
        if (validationRules.length !== 0) {
            const validationRuleGroup = validationRules.map(
                    Severity: Minor
                    Found in projects/ngx-dhis2-validation-rule-filter/src/lib/helpers/extract-validation-rule-group.helper.ts - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function exports has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    module.exports = function (config) {
  config.set({
    basePath: '',
    frameworks: ['jasmine', '@angular-devkit/build-angular'],
    plugins: [
                    Severity: Minor
                    Found in src/karma.conf.js - About 1 hr to fix

                      Function exports has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      module.exports = function (config) {
  config.set({
    basePath: '',
    frameworks: ['jasmine', '@angular-devkit/build-angular'],
    plugins: [
                      Severity: Minor
                      Found in projects/ngx-dhis2-validation-rule-filter/karma.conf.js - About 1 hr to fix

                        Function updateQueryString has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            function updateQueryString(key, value) {
        value = encodeURIComponent(value);

        var url = window.location.href;
        var re = new RegExp('([?&])' + key + '=.*?(&|#|$)(.*)', 'gi'),
                        Severity: Minor
                        Found in documentation/js/search/search.js - About 1 hr to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                                  if (linkContextId === 'additional') {
                            var mainToggler = activeMenu.querySelector(
                                '.chapter.' + linkContextId + ' div.menu-toggler'
                            );
                            if (mainToggler) {
                          Severity: Minor
                          Found in documentation/js/menu.js and 1 other location - About 50 mins to fix
                          documentation/js/menu.js on lines 240..247

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 51.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                              if (linkContextId === 'additional') {
                        var mainToggler = activeMenu.querySelector(
                            '.chapter.' + linkContextId + ' div.menu-toggler'
                        );
                        if (mainToggler) {
                          Severity: Minor
                          Found in documentation/js/menu.js and 1 other location - About 50 mins to fix
                          documentation/js/menu.js on lines 225..232

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 51.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Avoid deeply nested control flow statements.
                          Open

                                              if (toggler) {
                        toggler.click();
                    }
                          Severity: Major
                          Found in documentation/js/menu.js - About 45 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language