Showing 22 of 1,277 total issues
Function render
has 95 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
render(isNormalMode) {
let tp = lithtml.html(`
<nav>
<ul class="list">
<li class="title">
Function displayResults
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function displayResults(res) {
var noResults = res.count == 0;
var groups = {};
$searchResults.toggleClass('no-results', noResults);
File ngx-dhis2-validation-rule-filter.component.ts
has 264 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
import { Component, OnInit, EventEmitter, Output, Input } from '@angular/core';
import * as _ from 'lodash';
import { Store } from '@ngrx/store';
import { Observable } from 'rxjs';
import { State } from '../../store/reducers/validation-rule-groups.reducers';
Function bindSearch
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function bindSearch() {
// Bind DOM
$searchInputs = $('#book-search-input input');
$searchResults = $('.search-results');
Function getAllValidationRuleGroup
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
export function getAllValidationRuleGroup(apiResult: APIResult) {
if (apiResult.hasOwnProperty('validationRules')) {
const validationRules = apiResult.validationRules || [];
if (validationRules.length !== 0) {
const validationRuleGroup = validationRules.map(
Function ngOnInit
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
ngOnInit() {
this.currentPageAvailable = 1;
this.store.select(getAllValidationRuleGroups);
this.store.dispatch(new LoadValidationRuleGroups(this.dataSelection));
this.store
Function reducer
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
export function reducer(state = initialState, action: VRGActionTypes): State {
switch (action.type) {
case ValidationRuleGroupActions.LOAD_VALIDATION_RULE_GROUPS: {
return {
...state,
Function processLogos
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
var processLogos = function(entityLogo) {
for (var i = 0; i < entityLogos.length; i++) {
var entityLogo = entityLogos[i];
if (entityLogo) {
var url = entityLogo.getAttribute('data-src');
Function toggleItemMenu
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
toggleItemMenu = function(e) {
var element = $(e.target),
parent = element[0].parentNode,
parentLink,
elementIconChild;
Function getAllValidationRuleGroup
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
Open
export function getAllValidationRuleGroup(apiResult: APIResult) {
if (apiResult.hasOwnProperty('validationRules')) {
const validationRules = apiResult.validationRules || [];
if (validationRules.length !== 0) {
const validationRuleGroup = validationRules.map(
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function exports
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
module.exports = function (config) {
config.set({
basePath: '',
frameworks: ['jasmine', '@angular-devkit/build-angular'],
plugins: [
Function exports
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
module.exports = function (config) {
config.set({
basePath: '',
frameworks: ['jasmine', '@angular-devkit/build-angular'],
plugins: [
Function updateQueryString
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function updateQueryString(key, value) {
value = encodeURIComponent(value);
var url = window.location.href;
var re = new RegExp('([?&])' + key + '=.*?(&|#|$)(.*)', 'gi'),
Avoid deeply nested control flow statements. Open
Open
if (toggler) {
toggler.click();
}
Avoid deeply nested control flow statements. Open
Open
for(attr in value.attributes) {
if (DIRECTIVES[i].selector.indexOf(attr) !== -1) {
newNode.font = {
multi: 'html'
};
Avoid deeply nested control flow statements. Open
Open
if (COMPONENTS[j].name === newNodes[i].name) {
document.location.href = currentLocation.origin + currentLocation.pathname.replace(ACTUAL_COMPONENT.name, newNodes[i].name);
}
Avoid deeply nested control flow statements. Open
Open
if (toggler) {
toggler.click();
}
Avoid deeply nested control flow statements. Open
Open
if (linkContextId === 'additional') {
var mainToggler = activeMenu.querySelector(
'.chapter.' + linkContextId + ' div.menu-toggler'
);
if (mainToggler) {
Avoid deeply nested control flow statements. Open
Open
if (typeof obj[property][i] === 'string') {
obj[property].splice(i, 1);
}
Avoid deeply nested control flow statements. Open
Open
if (parentUl) {
parentChapterMenu = parentUl.parentNode;
if (parentChapterMenu) {
var toggler = parentChapterMenu.querySelector('.menu-toggler'),
elementIconChild = toggler.getElementsByClassName(