Sign upLogin

interfasys/galleryplus

View on GitHub
Star
controller/previewcontroller.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $appName,
        IRequest $request,
        IURLGenerator $urlGenerator,
        ConfigService $configService,
        ThumbnailService $thumbnailService,
Severity: Major
Found in controller/previewcontroller.php - About 1 hr to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public function __construct(
        $appName,
        IRequest $request,
        IURLGenerator $urlGenerator,
        ConfigService $configService,
    Severity: Major
    Found in controller/previewcontroller.php and 3 other locations - About 2 hrs to fix
    controller/filesapicontroller.php on lines 59..79
    controller/filescontroller.php on lines 59..79
    controller/previewapicontroller.php on lines 55..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function getThumbnails($ids, $square, $scale) {
        $idsArray = \explode(';', $ids);

        foreach ($idsArray as $id) {
            // Casting to integer here instead of using array_map to extract IDs from the URL
    Severity: Major
    Found in controller/previewcontroller.php and 1 other location - About 1 hr to fix
    controller/previewapicontroller.php on lines 92..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status