app/controllers/admin/account_activities_controller.rb
User controlled method execution Open
Open
params[:q][:created_at_gteq] = Date.send(default_date).strftime("%Y-%m-%d")- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Using unfiltered user data to select a Class or Method to be dynamically sent is dangerous.
It is much safer to whitelist the desired target or method.
Unsafe use of method:
method = params[:method]
@result = User.send(method.to_sym)Safe:
method = params[:method] == 1 ? :method_a : :method_b
@result = User.send(method, *args)Unsafe use of target:
table = params[:table]
model = table.classify.constantize
@result = model.send(:method)Safe:
target = params[:target] == 1 ? Account : User
@result = target.send(:method, *args)Including user data in the arguments passed to an Object#send is safe, as long as the method can properly handle potentially bad data.
Safe:
args = params["args"] || []
@result = User.send(:method, *args)Method index has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def index
ca_cache = params[:q][:created_at_lteq]
begin
end_time = params[:q][:created_at_lteq].try(:to_date)
params[:q][:created_at_lteq] = end_time.try(:end_of_day)- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"