internetee/registry

View on GitHub
app/controllers/epp/domains_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
91%

File domains_controller.rb has 255 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'deserializers/xml/domain_delete'
module Epp
  class DomainsController < BaseController
    before_action :find_domain, only: %i[info renew update transfer delete]
    before_action :find_password, only: %i[info update transfer delete]
Severity: Minor
Found in app/controllers/epp/domains_controller.rb - About 2 hrs to fix

Method dnskey_update_enabled has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def dnskey_update_enabled
      find_domain

      if @domain.dnskey_update_enabled? && !params[:parsed_frame].css('update').empty?
        flag = true
Severity: Minor
Found in app/controllers/epp/domains_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status