Sign upLogin

internetee/registry

View on GitHub
Star
app/models/registrant_user.rb

Summary

Maintainability
A
1 hr
Test Coverage
B
88%

Method find_or_create_by_api_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def find_or_create_by_api_data(user_data = {})
      return false unless user_data[:ident]
      return false unless user_data[:first_name]
      return false unless user_data[:last_name]
Severity: Minor
Found in app/models/registrant_user.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_or_create_by_user_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def find_or_create_by_user_data(user_data = {})
      return unless user_data[:first_name]
      return unless user_data[:last_name]
      return unless user_data[:ident]
      return unless user_data[:country_code]
Severity: Minor
Found in app/models/registrant_user.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method group_and_bulk_update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def group_and_bulk_update(contacts)
    contacts.group_by(&:registrar_id).each do |registrar_id, reg_contacts|
      bulk_action, action = actions.create!(operation: :bulk_update) if reg_contacts.size > 1
      reg_contacts.each do |c|
        if c.save(validate: false)
Severity: Minor
Found in app/models/registrant_user.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status