Sign upLogin

internetee/registry

View on GitHub
Star
app/models/registrar.rb

Summary

Maintainability
B
5 hrs
Test Coverage
A
98%

Class Registrar has 32 methods (exceeds 25 allowed). Consider refactoring.
Wontfix

class Registrar < ApplicationRecord # rubocop:disable Metrics/ClassLength
  include Versions # version/registrar_version.rb
  include Registrar::BookKeeping
  include EmailVerifable
  include Registrar::LegalDoc
Severity: Minor
Found in app/models/registrar.rb - About 3 hrs to fix

File registrar.rb has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Registrar < ApplicationRecord # rubocop:disable Metrics/ClassLength
  include Versions # version/registrar_version.rb
  include Registrar::BookKeeping
  include EmailVerifable
  include Registrar::LegalDoc
Severity: Minor
Found in app/models/registrar.rb - About 2 hrs to fix

Method issue_prepayment_invoice has 53 lines of code (exceeds 40 allowed). Consider refactoring.
Open

  def issue_prepayment_invoice(amount, description = nil, payable: true)
    invoice = invoices.create!(
      issue_date: Time.zone.today,
      due_date: (Time.zone.now + Setting.days_to_keep_invoices_active.days).to_date,
      description: description,
Severity: Major
Found in app/models/registrar.rb - About 1 hr to fix

Method replace_nameservers has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def replace_nameservers(hostname, new_attributes, domains: [])
    transaction do
      domain_scope = domains.dup
      domain_list = []
      failed_list = []
Severity: Minor
Found in app/models/registrar.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status