intracom-telecom-sdn/multinet

View on GitHub
util/multinet_requests.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function broadcast_cmd has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def broadcast_cmd(worker_ip_list, worker_port_list, opcode, data=None):
    """Broadcast a POST request to all the workers
    Use multiple processes to send POST requests to a specified
    endpoint of all the workers simultaneously.

Severity: Minor
Found in util/multinet_requests.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function make_post_request_runner has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def make_post_request_runner(host_ip, host_port, route, data, queue):
Severity: Minor
Found in util/multinet_requests.py - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status