intraxia/wp-gistpen

View on GitHub
client/deltas/jobsDelta.ts

Summary

Maintainability
F
3 days
Test Coverage

File jobsDelta.ts has 255 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Kefir, { Observable, Stream, Property } from 'kefir';
import { ofType } from 'brookjs';
import * as t from 'io-ts';
import { Nullable } from 'typescript-nullable';
import { ajax$ } from 'kefir-ajax';
Severity: Minor
Found in client/deltas/jobsDelta.ts - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

              return Kefir.never();
    Severity: Major
    Found in client/deltas/jobsDelta.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                return Kefir.never();
      Severity: Major
      Found in client/deltas/jobsDelta.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return Kefir.merge(jobs$);
        Severity: Major
        Found in client/deltas/jobsDelta.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return Kefir.merge([job$, runs$]);
          Severity: Major
          Found in client/deltas/jobsDelta.ts - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    const job$ = Kefir.concat<RootAction, never>([
                      Kefir.constant(jobFetchStarted()),
                      ajax$(job.response.rest_url, {
                        method: 'GET',
                        credentials: 'include',
            Severity: Major
            Found in client/deltas/jobsDelta.ts and 1 other location - About 1 day to fix
            client/deltas/jobsDelta.ts on lines 213..237

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 226.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    const job$ = Kefir.concat<RootAction, never>([
                      Kefir.constant(jobFetchStarted()),
                      ajax$(job.response.rest_url, {
                        method: 'GET',
                        credentials: 'include',
            Severity: Major
            Found in client/deltas/jobsDelta.ts and 1 other location - About 1 day to fix
            client/deltas/jobsDelta.ts on lines 151..175

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 226.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            const runStatus = t.union([
              t.literal('scheduled'),
              t.literal('running'),
              t.literal('paused'),
              t.literal('finished'),
            Severity: Major
            Found in client/deltas/jobsDelta.ts and 1 other location - About 1 hr to fix
            client/deltas/jobsDelta.ts on lines 46..52

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  level: t.union([
                    t.literal('error'),
                    t.literal('warning'),
                    t.literal('success'),
                    t.literal('info'),
            Severity: Major
            Found in client/deltas/jobsDelta.ts and 1 other location - About 1 hr to fix
            client/deltas/jobsDelta.ts on lines 69..75

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status