intridea/green_onion

View on GitHub

Showing 3 of 3 total issues

Method skin has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def skin(url)
      GreenOnion.configure do |c|
        c.skins_dir = options[:dir] if options[:dir]
        c.threshold = options[:threshold] if options[:threshold]
        c.dimensions = { :width => options[:width], :height => options[:height] } if options[:width] && options[:height]
Severity: Minor
Found in lib/green_onion/cli.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method skin_namespace_hash has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def skin_namespace_hash(options = {})
      { 
        :match   =>  options[:match] ? options[:match] : /[\/]/, 
        :replace =>  options[:replace] ? options[:replace] : "_", 
        :prefix  =>  options[:prefix] ? options[:prefix] : nil,
Severity: Minor
Found in lib/green_onion/configuration.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method skin_picker has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def skin_picker(url, type, threshold=100)
      if(@screenshot.paths_hash.length > 1)
        puts "\n" + url.color(:cyan)
        if type[:percentage]
          @compare.percentage_diff(@screenshot.paths_hash[:original], @screenshot.paths_hash[:fresh])
Severity: Minor
Found in lib/green_onion.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language