Sign upLogin

intuit/aws_account_utils

View on GitHub
Star

Showing 9 of 9 total issues

Class AwsAccountUtils has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

  class AwsAccountUtils
    attr_reader :log_level, :logger, :browser, :screenshots

    def initialize(log_level: :info, logger: nil, browser: nil, screenshots: nil)
      @log_level = log_level
Severity: Minor
Found in lib/aws_account_utils.rb - About 4 hrs to fix

    Method delete_all_keys has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def delete_all_keys
      tries ||= 4
      browser.link(:text => 'Delete').when_present.click
      logger.debug "Deleting access_key: #{browser.div(:id => 'modal-content').strong.text}"
      browser.div(:text => /Are you sure you want to delete the access key/).wait_until_present
    Severity: Minor
    Found in lib/aws_account_utils/root_access_keys.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method delete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def delete(account_email, account_password)
      logger.debug "Deleting root access/secret key"
      Login.new(logger, browser).execute url,
                                         account_email,
                                         account_password
    Severity: Minor
    Found in lib/aws_account_utils/root_access_keys.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          raise ArgumentError, "contact_info: must be a hash." unless contact_info.is_a?(Hash)

      resp = alternate_contacts.set account_email, account_password, contact_info
      logger.info 'Set alternate contacts.' if resp
      resp
    Severity: Minor
    Found in lib/aws_account_utils.rb and 1 other location - About 20 mins to fix
    lib/aws_account_utils.rb on lines 140..147

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          raise ArgumentError, "answers: must be a hash." unless answers.is_a?(Hash)

      resp = challenge_questions.create account_email, account_password, answers
      logger.info 'Security Challenge Questions have been setup' if resp
      resp
    Severity: Minor
    Found in lib/aws_account_utils.rb and 1 other location - About 20 mins to fix
    lib/aws_account_utils.rb on lines 150..157

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def confirm_consolidated_billing(account_email:, account_password:, confirmation_link:)
      resp = consolidated_billing.confirm account_email, account_password, confirmation_link
      logger.info 'Consolidated billing has been confirmed' if resp
      resp
    ensure
    Severity: Minor
    Found in lib/aws_account_utils.rb and 3 other locations - About 15 mins to fix
    lib/aws_account_utils.rb on lines 51..57
    lib/aws_account_utils.rb on lines 131..137
    lib/aws_account_utils.rb on lines 159..165

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def set_company_name(account_email:, account_password:, name:)
      resp = company_name.set account_email, account_password, name
      logger.info 'Set company name.' if resp
      resp
    ensure
    Severity: Minor
    Found in lib/aws_account_utils.rb and 3 other locations - About 15 mins to fix
    lib/aws_account_utils.rb on lines 51..57
    lib/aws_account_utils.rb on lines 67..73
    lib/aws_account_utils.rb on lines 131..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def change_root_password(account_email:, account_password:, new_password:)
      resp = password.change(account_email, account_password, new_password)
      logger.info 'Changed root password.' if resp
      resp
    ensure
    Severity: Minor
    Found in lib/aws_account_utils.rb and 3 other locations - About 15 mins to fix
    lib/aws_account_utils.rb on lines 67..73
    lib/aws_account_utils.rb on lines 131..137
    lib/aws_account_utils.rb on lines 159..165

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def request_consolidated_billing(master_account_email:, master_account_password:, account_email:)
      resp = consolidated_billing.request master_account_email, master_account_password, account_email
      logger.info 'Consolidated billing has been requested' if resp
      resp
    ensure
    Severity: Minor
    Found in lib/aws_account_utils.rb and 3 other locations - About 15 mins to fix
    lib/aws_account_utils.rb on lines 51..57
    lib/aws_account_utils.rb on lines 67..73
    lib/aws_account_utils.rb on lines 159..165

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language