Sign upLogin

intuit/aws_account_utils

View on GitHub
Star

Showing 3 of 9 total issues

Class AwsAccountUtils has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

  class AwsAccountUtils
    attr_reader :log_level, :logger, :browser, :screenshots

    def initialize(log_level: :info, logger: nil, browser: nil, screenshots: nil)
      @log_level = log_level
Severity: Minor
Found in lib/aws_account_utils.rb - About 4 hrs to fix

    Method delete_all_keys has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def delete_all_keys
      tries ||= 4
      browser.link(:text => 'Delete').when_present.click
      logger.debug "Deleting access_key: #{browser.div(:id => 'modal-content').strong.text}"
      browser.div(:text => /Are you sure you want to delete the access key/).wait_until_present
    Severity: Minor
    Found in lib/aws_account_utils/root_access_keys.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method delete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def delete(account_email, account_password)
      logger.debug "Deleting root access/secret key"
      Login.new(logger, browser).execute url,
                                         account_email,
                                         account_password
    Severity: Minor
    Found in lib/aws_account_utils/root_access_keys.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language