Sign upLogin

io-digital/tephra

View on GitHub
Star

Showing 11 of 11 total issues

Function constructor has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(
    SHARED_SECRET,
    AUTH_PORT,
    ACCT_PORT,
    COA_PORT,
Severity: Minor
Found in src/index.js - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    module.exports = function accounting_respond(
  decoded,
  rinfo,
  attributes,
  vendor_attributes,
    Severity: Major
    Found in src/accounting_respond.js and 2 other locations - About 40 mins to fix
    src/access_accept.js on lines 2..18
    src/access_reject.js on lines 2..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    module.exports = function access_reject(
  decoded,
  rinfo,
  attributes,
  vendor_attributes,
    Severity: Major
    Found in src/access_reject.js and 2 other locations - About 40 mins to fix
    src/access_accept.js on lines 2..18
    src/accounting_respond.js on lines 2..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    module.exports = function access_accept(
  decoded,
  rinfo,
  attributes,
  vendor_attributes,
    Severity: Major
    Found in src/access_accept.js and 2 other locations - About 40 mins to fix
    src/access_reject.js on lines 2..18
    src/accounting_respond.js on lines 2..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Consider simplifying this complex logical expression.
    Open

            if (!(
          typeof dict.vendor === 'string' &&
          dict.vendor.length &&
          typeof dict.path === 'string' &&
          dict.path.length &&
    Severity: Major
    Found in src/index.js - About 40 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        var decoded = decode.call(
    this,
    message,
    function(packet) {
      return packet.code === 'Accounting-Request'
      Severity: Minor
      Found in src/acct_on_message.js and 1 other location - About 40 mins to fix
      src/auth_on_message.js on lines 7..14

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        var decoded = decode.call(
    this,
    message,
    function(packet) {
      return packet.code === 'Access-Request'
      Severity: Minor
      Found in src/auth_on_message.js and 1 other location - About 40 mins to fix
      src/acct_on_message.js on lines 6..13

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        decoded,
  rinfo,
  attributes,
  vendor_attributes,
  on_rejected
      Severity: Minor
      Found in src/access_reject.js - About 35 mins to fix

        Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          packet,
  code,
  attributes,
  vendor_attributes,
  on_error
        Severity: Minor
        Found in src/encode_response.js - About 35 mins to fix

          Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            decoded,
  rinfo,
  attributes,
  vendor_attributes,
  on_responded
          Severity: Minor
          Found in src/accounting_respond.js - About 35 mins to fix

            Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              decoded,
  rinfo,
  attributes,
  vendor_attributes,
  on_accepted
            Severity: Minor
            Found in src/access_accept.js - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language